[Buildbot-devel] Bug in status/mail.py

[Brian Warner]

"Grig Gheorghiu" <grig at agilistas.org> writes:

> ...
> This is because in the MailNotifier:buildFinished method, self.mode is
> only compared against "failing" and "problem". If it is neither, it is
> assumed to be "all", and the method returns self.buildMessage(name,
> build, results).

I've added an assert to that function to catch this problem earlier (during
the reconfig window). Thanks for spotting that!

cheers,
 -Brian