[Buildbot-devel] addLogObserver and progressMetrics

[Brian Warner]

On Sat, 24 Nov 2007 13:06:32 -0500
"Sergey A. Lipnevich" <sergey at optimaltec.com> wrote:

> In 0.7.6, adding log observer that produces new metrics is tricky
> because each new metric must be also mentioned in build step's
> progressMetrics member. Would it be better instead to declare all
> metrics provided by log observer in its class, and automatically add
> new metrics names to progressMetrics once the observer instance is
> added? I can file a ticket and submit a patch, I'm asking here first
> if it's a good idea to make this change.

I think that's a good idea. You'll need to double-check that the
"expectations" are still filled in correctly.. it's been a long time since I
looked at that code, but I seem to remember there is a place where we run
through all steps and fill them with expectations from the previous build.
We'd need to make sure that we enumerate the metrics before doing this
setting-expectations phase.

thanks!
 -Brian