[Buildbot-devel] Patch to detect warnings in Test and Compile steps
rochg at bakbone.co.uk
Wed Aug 1 14:45:44 UTC 2007
On 17 Jul 2007, at 16:51, Greg Ward wrote:
> On 7/17/07, Roch Gadsdon <rochg at bakbone.co.uk> wrote:
>> b) Allow for a set of regexp patterns to be specified for Compile and
>> Test steps. All of these pattterns are checked when looking for
>> warnings. We could provide some default patterns that catch common
>> cases for C/C++/whatever, but the user then has the freedom to
>> override the patterns when they setup the step in their config file.
>> Possibly introduces a class between ShellCommand and Compile/Test to
>> share the functionality.
> IMHO option (b) is much better. Searching for /\bwarning\b/ will
> probably work 95% of the time -- I imagine it will work for Java
> command-line compilers as well as gcc, for instance -- but it's the
> sort of thing that people should be allowed to override trivially,
> without having to write subclasses.
Hopefully better late than never, I have posted a revised patch that
I think takes on board the discussion from last time. There is a new
intermediate class between ShellCommand and Compile/Test that allows
for a regular expression to be used to specify what counts as a
warning. By default this is set to "warning[: ]", but the user can
override this in their config file when adding a step.
Any further feedback from Greg / anyone is very welcome. Especially,
others may have better ideas on what the default regular expression
The patch is Trac ticket #74 - http://buildbot.net/trac/ticket/74
-- Roch Gadsdon
More information about the devel