[Buildbot-devel] AssertionError: Scheduler 'trunkscheduler' uses unknown builder 'factory'

[Scott Lamb]

On Sep 17, 2006, at 2:01 PM, Brian Warner wrote:
> This interface (using dictionaries to describe the Builder) was  
> probably the
> very first one I created in Buildbot, and it really doesn't behave  
> like
> everything else in the config file. (back in those days I was  
> thinking that a
> web page where you could configure everything wouldn't be too far  
> off, so I
> was trying to make that easier by restricting the config to flat  
> data rather
> than using instances everywhere).
>
> I'm tempted to change this at some point. Maybe something like:
>
>  b1 = Builder(name="fast-builder", slavename="machine3",
>               builddir="fast-builder", factory=f1)

That would be cool. I like consistency, and I think this way is better:

* It tells me where to find the pydocs or code associated with it.

* I trust constructors more. I haven't checked this code, but when  
using similar interfaces, I've made a one-character typo in the key  
name. My new argument got ignored, the default got used, and I got  
frustrated debugging it. In contrast, I know Python's method call  
behavior - it'll complain about invalid arguments unless someone's  
being a little too fancy with **kwargs.

-- 
Scott Lamb <http://www.slamb.org/>