[Buildbot-devel] Perforce (P4) commit trigger

[Scott Lamb]

On 1 Sep 2006, at 23:50, Scott Lamb wrote:
> p4poller works and is unit tested. On the other hand, if you're set  
> on triggers instead of polling, you should be able to extract half  
> of p4poller.P4Source into a new P4AbstractSource base class, then  
> wrap it in a change-commit trigger like:

[...]

On second thought, this wouldn't work because the P4Source assumes  
it's run from within the buildmaster. You'd also need to send the  
Change object over pb instead of just doing what P4Source does:

             self.parent.addChange(c)

svn_buildbot.py has an example of doing that.

-- 
Scott Lamb <http://www.slamb.org/>