[Buildbot-devel] SvnSource poller

[Niklaus Giger]

Am Montag, 2. Oktober 2006 02:25 schrieb Brian Warner:
> I spent the weekend working on the SvnSource code developed by Niklaus and
> others, and have finally checked it in. Thank you guys so much for writing
> this! I rearranged a lot of stuff.. I hope it still works in a useful way.
>
> Could the folks who were involved with this take a look at the latest
> CVS/Darcs and review my changes?
After being away a few days and having guests, I took a look at your changes.
Thank you a lot for reworking my proposed patches. I am learning more Python 
and a buildbot internals.

> I changed the API so that for situations where you're only following trunk
> you only have to provide one parameter, the svn URL that points at the top
> of the tree of interest. If you want to follow multiple branches at once,
> you have to provide a "split_file" function that knows about your branch
> naming policy. There are a lot of docs and examples in the User's Manual
> that I hope will explain how to use split_file().
I had no problem with these changes and they make sense to me.

<..>
>  Rather than setting the Change's timestamp to the value provided by the
> SVN server (which seemed to be in the server's timezone when I tried it), I
> just had the ChangeMaster assign the current time to each Change as it is
> submitted. Before doing this, I found that the Changes appeared several
> hours in the future, messing up the Waterfall display.
Good idea.
>
>  I took the unicode objects returned by minidom for filenames and forced
> them back into ascii, since sometimes they get included in commands and
> that would cause some problems. I left "comments" and "author" as unicode,
> but fixed up the HTML-rendering code that wasn't able to deal with it. I
> suspect that some other status targets may get screwed up by this, but I'd
> rather discover those and fix them than forbid unicode everywhere.
> Eventually I'd like everything to be unicode-clean but I suspect it will
> take a while.
Adding comments with german Umlauts and french accents worked in my 
environment (using konqueror as a web browser). But I am not sure whether the 
generated HTML code is correct.

> If you could, please see if you can make the new code do the things that
> the old code did. Hopefully I didn't break any of the functionality when I
> dived in and started rearranging everything.

I ran a few simple tests here and things behaved the way I expected.

I just noted the following small problem:
Specifiying (note the missing slash at the end of the URL)
c['buildbotURL'] = "http://localhost:8081"
generated in the build displays section "Steps and Logfiles:" (e.g. 
http://localhost:8081/svn-better/builds/2) incorrect references like
http://localhost:8081svn-better/builds/2/step-svn)

I do not now whether it is new or not.

Thanks for your great work!

-- 
Niklaus Giger