[Buildbot-devel] Re: release clock started. Still problems with properties

[Niklaus Giger]

Brian Warner wrote:

Hi Brian

I did run the testsuite under GNU/Debian Linux on my Powerbook with the
following result
[TODO]: buildbot.test.test_web.GetURL.testBrokenStuff

Reason: 'not implemented yet'
  File "/mnt/data.ng/src/buildbot.baz/trunk/buildbot/test/test_web.py", line
330, in testBrokenStuff
    self.assertURLEqual(s.getSchedulers()[0], "schedulers/0")
  File "/mnt/data.ng/src/buildbot.baz/trunk/buildbot/test/test_web.py", line
309, in assertURLEqual
    self.failUnlessEqual(got, full_expected)
twisted.trial.unittest.FailTest:
None != 'http://dummy.example.org:8010/schedulers/0'
===============================================================================
[ERROR]: buildbot.test.test_changes.SVNPoller.testSvnRepo

  File "/usr/lib/python2.3/site-packages/twisted/internet/task.py", line 77,
in stop
    assert self.running, ("Tried to stop a LoopingCall that was "
exceptions.AssertionError: Tried to stop a LoopingCall that was not running.
-------------------------------------------------------------------------------
Ran 197 tests in 309.883s

Then I tried to use the properties. I can only use the 'slavename'. All
others get me exceptions. My master.cfg had entries like this:
steps = [s(step.SVN, svnurl="file:///tmp/svn_repo/tst"),
     s(ShellCommand,   command=["echo", 
                                  WithProperties("build-%s", "slavename"), "slavename"
                                  ]),
     s(ShellCommand, command=["echo",
        WithProperties("build-%s", "slavename"), "slavename",
        WithProperties("build-%s", "slavename"), "slavename",
        #WithProperties("build-%(branch)",  "branch"),  "branch",
        #WithProperties("build-%(got_revision)",  "got_revision"),  "got_revision",
        #WithProperties("build-%(buildnumber)",  "buildnumber"),  "buildnumber",
        ],
      ),



Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/buildbot/process/step.py", line
511, in startStep
    d.addCallback(self._startStep_2)
  File "/usr/lib/python2.3/site-packages/twisted/internet/defer.py", line
191, in addCallback
    callbackKeywords=kw)
  File "/usr/lib/python2.3/site-packages/twisted/internet/defer.py", line
182, in addCallbacks
    self._runCallbacks()
  File "/usr/lib/python2.3/site-packages/twisted/internet/defer.py", line
307, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
--- <exception caught here> ---
  File "/usr/lib/python2.3/site-packages/buildbot/process/step.py", line
534, in _startStep_2
    skip = self.start()
  File "/usr/lib/python2.3/site-packages/buildbot/process/step.py", line
995, in start
    command = self._interpolateProperties(self.command)
  File "/usr/lib/python2.3/site-packages/buildbot/process/step.py", line
976, in _interpolateProperties
    command_argv.append(argv.render(self.build))
  File "/usr/lib/python2.3/site-packages/buildbot/process/step.py", line
872, in render
    s = self.fmtstring % tuple(strings)
exceptions.TypeError: format requires a mapping

Best regards

Niklaus