[Buildbot-devel] Patch fixing [1452801] MailNotifier gives invalid Builder URL

[Olivier Bonnet]

https://sourceforge.net/tracker/index.php?func=detail&aid=1452801&group_id=73177&atid=537001

Another small fix: getURLForThing() already returns an escaped URL, so
it shouldn't be escaped twice (the resulting URL is invalid, as
described in the bug)

Olivier

--- orig/buildbot/status/mail.py
+++ mod/buildbot/status/mail.py
@@ -233,8 +233,7 @@
             text += "The Buildbot has detected a new failure of %s.\n" % name
         buildurl = self.status.getURLForThing(build)
         if buildurl:
-            text += ("Full details are available at:\n %s\n" %
-                     urllib.quote(buildurl, '/:'))
+            text += "Full details are available at:\n %s\n" % buildurl
         text += "\n"

         url = self.status.getBuildbotURL()