[Buildbot-devel] null values of revision from WithProperties

[Brian Warner]

>     144         , step.WithProperties("RELEASE=0.%(revision)s")
> 
> 	scons DISTTAR_NAME=ascend RELEASE=0. dist

> *Can anyone suggest what I might be doing wrong here? Could it be due to
> the fact that I used a "forced build", simply?

Yup, that's it exactly. "force build" (without specifying a particular
revision number) sets revision=None, which means "get the latest HEAD". You
can force builds *with* a particular revision, in which case %(revision)s
will work as you expect, but of course then you have to decide ahead of time
which revision you want to build.

You probably want to use %(got_revision)s instead, which will ask the
buildslave to look at the tree it checked out and report back the revision
that was actually acquired. This will work for both builds of specific
revisions and for builds of HEAD. It requires an 0.7.3 or newer buildslave,
though.. 0.7.2 and earlier don't do the got_revision check, so the
%(got_revision)s property is always None.

Should empty/unknown/None build properties show up as UNKNOWN or something
more visible than an empty string? Or throw an exception?

cheers,
 -Brian