[Buildbot-devel] Re: [Python-Dev] buildbot

[Stefan Seefeld]

Martin v. Löwis wrote:

> Not sure whether we are talking about the same patch, then. I was
> looking at
> 
> http://sourceforge.net/mailarchive/message.php?msg_id=13977004
> 
> This removes the closing of the options list, plus
> some functions that follow it (__init__, opt_include,
> opt_filter, opt_exclude). I believe you that your version
> works for you, but I doubt that your version matches
> the patch. Just try applying the patch to the stock
> svn_version.py, and see how the resulting file is
> syntactically incorrect.

Ok, looking at the patch itself I can confirm it is wrong. Not
sure how I produced that patch then. I guess it was taken in the
middle of an edit session. Sorry for my sloppyness.

I have indeed removed some of the options (such as the
exclusion/inclusion stuff), as they made no sense to me after
I used the branch matching function. In fact I hoped to be able
to come up with two parts: a generic function to be called
as a post-commit hook, and a user-provided data file providing
the mapping logic from svn change sets to change sets as seen by
the buildbot (i.e. per branch).

Regards,
		Stefan