[Buildbot-devel] Re: [Python-Dev] buildbot

[Stefan Seefeld]

Martin v. Löwis wrote:
> Brian Warner wrote:
> 
>>There was also a patch[1] to add some regexps to svn_buildbot.py to do this
>>kind of branch determination. I haven't been able to review it properly yet,
>>but it may give you some ideas.
> 
> 
> The patch itself is completely broken. It removes random parts of
> svn_buildbot.py, so after applying it, svn_buildbot isn't even
> syntactically correct anymore.

Well, I never intended the patch to be applied as-is (as I stated in the
original mail), but I don't believe it is 'completely' broken either,
or else I wouldn't have been able to use it.
I can easily see it not working in situations I haven't tested it in,
though, such as different repository layouts.

> However, I adjusted the patch, so it now works fine.
> (the other issue was that the regex was not entirely correct:
> it assumes a trunk/<project> structure, where we have a
> <project>/trunk structure).

Great. Would you mind sharing your fixes ? Hopefully it will improve
to the point where it can be put into mainline at some point...

Thanks,
		Stefan