[Buildbot-devel] RFE: load management for build slaves
warner-buildbot at lothar.com
Mon Apr 24 09:16:48 UTC 2006
> Interesting ! Brian, any chance of reviewing this patch before the upcoming
> release, and, in fact, the rest of my proposal ?
The multi-owner lock change is a bit too big to make it into the next
release, given how soon I hope it will happen (another day or two). I looked
it over briefly this afternoon.. there's a potential race condition when the
locks are released (and the next hopeful build claims it), that should
probably be solved with a callLater(0), which in turn necessitates the
removal of an assert(). Also, it really needs unit tests before it can go in,
the code looks correct to me (apart from those problems) but this lock stuff
makes me nervous without tests. I'll comment more on the SF#1434997 bug
I haven't had a chance to think about your ideas on concurrency yet :(. I'll
try to circle back around to them after the release.
More information about the devel