[Buildbot-devel] SvnChangeSource was Re: RFC: more flexible web status display

[Scott Lamb]

On Apr 18, 2006, at 12:58 AM, Brian Warner wrote:
>> Hey, if you're going to be using p4poller as an example, use the
>> attached one instead. It makes some improvements:
>> ...
>> This is part of a patch in progress.
>
> Excellent.. let me know when you feel it's done and I'll commit the  
> new
> version.
>
> One of these days we should sit down and write up some proper P4  
> handling,
> complete with test cases (since the free version of p4d is complete  
> enough to
> use in test_vc just like the other VC systems that buildbot can  
> handle).

Already done. :) It just needs a bit more polish, updates to apply to  
current CVS, and documentation.

There are at least a few cases the tests don't cover, though:

- We had been deleting the clients after using them and weren't using  
the sourcedata, so there was a bug in which switching branches would  
leave around files that were in the old branch but not the new. No  
test caught it.

- Perforce (and CVS I believe) doesn't version directories; it just  
has an "rmdirs" option in the client spec. These leftover empty  
directories are significant to some build systems (i.e., ours) so we  
need this non-default option set.

- Perforce has a "nomodtime" option that sets files' modification  
times to when they were _submitted_, not when they were synced to the  
working copy. I'm sure setting that would break _everything_ in  
mode='update' or mode='copy'.

-- 
Scott Lamb <http://www.slamb.org/>