[Buildbot-devel] Re: patch to add step.ShellCommands (plural)

Trent Mick trentm at gmail.com
Wed Apr 5 20:55:52 UTC 2006


> For some of my buildbot factories I find I want a build step that
> takes multiple shell commands (instead of just the one that you can
> get with step.ShellCommand). I am have attached a patch that adds a
> ShellCommands class to buildbot/process/step.py. It is, of course,
> heavily based on ShellCommand with the main diffs being in start() and
> the new _runNextCommand() callback for serializing the multiple
> commands. I have tested this and am using it in one of my buildbots.
>
> Could this be considered for inclusion in the buildbot core?

Attached is an improvement to ShellCommands that adds proper handling
for interrupting the step: remaining commands are skipped and failure
status is set.

Trent

--
Trent Mick
trentm at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildbot-step-ShellCommands-take2.patch
Type: application/octet-stream
Size: 11289 bytes
Desc: not available
URL: <http://buildbot.net/pipermail/devel/attachments/20060405/97498ab2/attachment.obj>


More information about the devel mailing list