[Buildbot-devel] Problem with dnotify.py on AMD64

[Brad Hards]

On Thursday 29 September 2005 22:16 pm, Jeff Pitman wrote:
> I might be smoking something, but I think you either found a bug in
> python or in glibc.  Peel it apart, find out where that Overflow is
> coming from.  Is it from glibc and python is just forwarding it up?  Or
> is the check done in the wrapper code?
It is coming from the core python code. I  have submitted a patch for the bug 
(http://sourceforge.net/tracker/index.php?func=detail&aid=1309352&group_id=5470&atid=305470) 
but that isn't all that likely to get backported, and even if it does, it  
will require everyone to get to at least 2.4.3. 

> Either way, getting a fix pushed out is going to take some time. (Time
> for hackery in dnotify??)
Hacking dnotify (which I guess would be to do resubmitted one-shot) would 
require more python-fu than I have to avoid a race.
Instead, how about a simpler change to maildir.py?
[bradh at marginata buildbot--dev--0--patch-317]$ tla file-diff 
buildbot/changes/maildir.py
--- orig/buildbot/changes/maildir.py
+++ mod/buildbot/changes/maildir.py
@@ -52,8 +52,9 @@
             try:
                 self.dnotify = DNotify(self.newdir, self.dnotify_callback,
                                        [DNotify.DN_CREATE])
-            except IOError:
-                # probably linux<2.4.19, which doesn't support dnotify
+            except (IOError, OverflowError):
+                # IOError is probably linux<2.4.19, which doesn't support 
dnotify
+                # Overflow error will occur on some 64-bit machines because 
of a python bug
                 print "DNotify failed, falling back to polling"
                 have_dnotify = 0


Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://buildbot.net/pipermail/devel/attachments/20050930/440f0d28/attachment.bin>