[Buildbot-devel] [PATCH] Crash when using buildbot try on an SVN repo

Brian Warner warner-buildbot at lothar.com
Fri Oct 28 14:55:16 UTC 2005

> I experienced a crash using the "buildbot try" command in the 0.7.0 release
> of buildbot. The error message was along the lines of "len called on a
> zero-length object" in the "ns" function. The attached patch fixes it.


> For subversion, baserev is an integer, so calling len() on it raises an
> exception. It would seem that "ns" expects a string, so cast it to one
> before calling.

Yeah, I'm really starting to think that 'revision' values (including the
'baserev' used by try) should be strings everywhere. The mixed int/str
convention causes other problems, like how to display them in the HTML pages,
so I'm probably going to start converting them all to be strings, at least on
the input side. The args['revision'] value sent from the buildmaster to the
buildslave for the 'svn' command will probably remain a string, since by that
point we *know* we're dealing with subversion and not some other VC system.
Before that point, all the VC systems are handled alike.


PS: yay! somebody's using 'try'! :-)

More information about the devel mailing list