[Buildbot-devel] log file assertion error after master crashes hard

Brian Warner warner-buildbot at lothar.com
Fri Oct 7 03:30:57 UTC 2005

Yeah, I finally got rid of this assertion in the CVS code. Take a look at
buildbot/status/builder.py, the commit I did on 30-Aug-2005, and just copy
that into your current tree (I think it's sufficient to just comment out the
'assert' statement).

When I first put that in, I thought it would be a good idea to flag this
situation. But now I think it was the wrong thing to do, and silently
overwriting the log files for builds that have been performed but forgotten
about is better than failing the next N builds until the situation corrects

The better fix is to save out the Builder pickle more often (say, after every
build), but the last time I went to add that, there was a funny interaction
that made it non-trivial to implement, so it will have to wait until I have a
bit more time to fix it properly.


More information about the devel mailing list