[Buildbot-devel] Problem with dnotify.py on AMD64
Brian Warner
warner-buildbot at lothar.com
Sun Oct 2 23:15:44 UTC 2005
> Instead, how about a simpler change to maildir.py?
> [bradh at marginata buildbot--dev--0--patch-317]$ tla file-diff
> buildbot/changes/maildir.py
> --- orig/buildbot/changes/maildir.py
> +++ mod/buildbot/changes/maildir.py
> @@ -52,8 +52,9 @@
> try:
> self.dnotify = DNotify(self.newdir, self.dnotify_callback,
> [DNotify.DN_CREATE])
> - except IOError:
> - # probably linux<2.4.19, which doesn't support dnotify
> + except (IOError, OverflowError):
> + # IOError is probably linux<2.4.19, which doesn't support
> dnotify
> + # Overflow error will occur on some 64-bit machines because
> of a python bug
> print "DNotify failed, falling back to polling"
> have_dnotify = 0
Works for me. I'll apply this.
thanks,
-Brian
More information about the devel
mailing list