[Buildbot-devel] Retrieving build results

[Joel Becker]

On Tue, Nov 29, 2005 at 01:12:03AM -0800, Brian Warner wrote:
> Either this extra information (whether arguments like which tests to run, or
> build information like a revision and branch name) could be available to the
> BuildSteps and then they could be responsible for passing them into the
> remote commands, or it could be passed to *all* commands through environment
> variables. I'm inclined to go with the former, under the maxim that "explicit
> is better than implicit", but to make that useable I'd want to first make it
> easier to override the actual shell command being executed. This probably

	I'd combine the two.  Specific BuildStep classes (eg, CVS and
SVN) cook up their own commands already, so having them retrieve the
information in the python code is just fine.  The only problem is
ShellCommand, where you have to somehow get the info into the user's
command string.  Instead of a tricksy substitution, I'd just add an
argument for ShellCommand that explicitly specifies environment
variables to pass through.  Where today I have:

    s(step.ShellCommand, command=["./autogen.sh"], haltOnFailure=True),

I would be able to say:

    s(step.ShellCommand, command=["./autogen.sh"],
      env_args=['testcases'], haltOnFailure=True),

This would result in $testcases being available to the ShellCommand.

Joel

-- 

"Hell is oneself, hell is alone, the other figures in it, merely projections."
        - T. S. Eliot

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127