[Buildbot-devel] setting the description field for ShellCommand

Brian Warner warner-buildbot at lothar.com
Sat Nov 5 23:53:19 UTC 2005

> To allow me to run arbitrary shell commands and set the displayed
> description field, I wrote this object:

> ...

> This lets me write steps like this in the master.cfg file:
> s(step.DescribedShellCommand,
>                 command = ["cp", "foo/bar/baz/Makefile.foo", "."],
>                 description = ["build", "prep"],
>                 descriptionDone = ["prep done"])

Hrm. It was supposed to be possible to pass description= and descriptionDone=
arguments with ordinary ShellCommand subclasses already (take a look at
ShellCommand.__init__, particuarly the way it handles the 'parms' class-level
attribute). But I smell a bug there. It's using 'self.__class__.parms' to see
what kwargs it should pay attention to, and that doesn't allow subclasses to
override them.

I'll see if I can figure out why it's written that way and fix it.


More information about the devel mailing list