[Buildbot-devel] exception in Change.asHTML in 0.6.6

Brian Warner warner-buildbot at lothar.com
Tue May 24 19:05:23 UTC 2005


So, I'm an idiot, I added branch= to the Change object and then failed to add
a class-level attribute to accomodate old pickled Changes from 0.6.4 and
before. As a result, you'll get an exception if you use the HTML page to look
at any Changes that were created by those older versions.

Here's a quick patch to fix that. I'd like to make the next version include
more than a one-liner, but I also don't want to let the current version be
broken in this way for too long. I'm not sure what I'll end up doing.. maybe
I can find another few bugs to fix now and then do another release tonight.

"release early, release often",
 -Brian


Index: buildbot/changes/changes.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/changes/changes.py,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- buildbot/changes/changes.py	18 May 2005 07:49:29 -0000	1.24
+++ buildbot/changes/changes.py	24 May 2005 18:57:49 -0000	1.25
@@ -57,8 +57,10 @@
     else:
         __implements__ = interfaces.IStatusEvent,
 
-    links = []
     number = None
+
+    links = []
+    branch = None
     revision = None # used to create a source-stamp
 
     def __init__(self, who, files, comments, isdir=0, links=[],





More information about the devel mailing list