[Buildbot-devel] HTMLLogFile.upgrade missing ?

[Brian Warner]

> after upgrading to 0.6.5, a number of issues popped up.
> 
> The most important one of these seems to be:
>             l.upgrade(logfilename)
>         exceptions.AttributeError: HTMLLogFile instance has no attribute
> 'upgrade'

Doh! I missed that one. The fix is to add a dummy upgrade() method in
buildbot/status/builder.py:HTMLLogFile, around line 485:

    def upgrade(self, logfilename):
        pass

I'm working on a test case, and will commit the fix as soon as it's done.

> Another issue I found is that due to the change from .tap to .tac, the
> master.cfg does not get executed in the context of the basedir anymore.

I didn't think that PYTHONPATH was changed in either case.. python only adds
a directory like './foo' to the path when you run a program like 'python
./foo/bar.py'.

Ah, ok, bin/twistd has code to add os.getcwd() if you're not running as root,
and in an attempt to improve win32 compatibility (by reducing the number of
spawned processes) I changed 'buildbot start' to import and call twistd's
subroutines directly instead of spawning an actual 'twistd' executable. The
piece that I did not invoke was the preamble in bin/twistd that manipulates
sys.path .

I'll add that. As a workaround, you can just add it to your PYTHONPATH
manually, before starting the buildmaster.


(I've always put the passwords and such in a private.py file in an adjoining
'support-master/' directory, and then modified PYTHONPATH before startup to
include it.. it never occurred to me to put them in the same directory as the
master.cfg file, probably due to the funky way I push files over to the
Twisted buildbot's working directory).

With the other bugs in there ('buildbot stop' not working, 'buildbot
sendchange' not working, not using rawstrings meaning 'buildbot master' fails
under windows), it looks like 0.6.6 will be out very soon, probably today or
tomorrow.


sorry for the inconvenience,
 -Brian