[Buildbot-devel] FW: [Buildbot-commits] buildbot/buildbot/slave commands.py,1.31,1.32

[Mike Taylor]

Yep rmdir /s/q would have worked just fine but would have made a very 
small version dependency - not all versions of windows shells have the 
same behaviour for /s/q in my experiance.  And then you also have to 
worry about people running in shells that are not cmd.exe like cygwin 
or 4nt.

Small issues that most likely would not have been a problem but having 
a python solution makes it even more compatible.

---
Bear
http://code-bear.com

Open Source Applications Foundation (OSAF)
http://www.osafoundation.org

PGP Fingerprint = 9996 719F 973D B11B E111  D770 9331 E822 40B3 CD29


On May 13, 2005, at 7:57 PM, Nick Trout wrote:

>
>> buildbot/slave/commands.py (rmdirRecursive): added a check
>> to ensure the path passed into rmdirRecursive actually exists.
>> On win32 a non-existant path would generate an exception.
>
> You could just the following for NT/XP:
>
> 	rmdir /S /Q dirname
>
> Nick
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by Oracle Space Sweepstakes
> Want to be the first software developer in space?
> Enter now for the Oracle Space Sweepstakes!
> http://ads.osdn.com/?ad_ids93&alloc_id281&op=click
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
URL: <http://buildbot.net/pipermail/devel/attachments/20050513/ef897958/attachment.bin>