[Buildbot-devel] p4poller fix

Dobes Vandermeer dobesv at gmail.com
Thu Jun 30 23:07:13 UTC 2005


I noticed that p4poller doesn't handle filenames with spaces.  Here's a patch

Index: changes/p4poller.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/changes/p4poller.py,v
retrieving revision 1.4
diff -u -r1.4 p4poller.py
--- changes/p4poller.py	17 May 2005 10:14:09 -0000	1.4
+++ changes/p4poller.py	21 Jun 2005 22:10:43 -0000
@@ -109,7 +110,7 @@
         while lines:
             line = lines.pop(0).strip()
             if not line: continue
-            files.append(line.split(' ')[1])
+            files.append(' '.join(line.split(' ')[1:-1]))
         change['files'] = files
         return change




More information about the devel mailing list