[Buildbot-devel] Perforce Password Patch

[Charles Hardin]

I put the patch into sourceforge...

The unittest is going to take a bit more time in that I am not quite
sure how to fit it in... I played with trying to get it into test_vc,
but since perforce is always client server it made it a little hard to
figure out...

The reality is that I need to think a bit more about what the test case
should accomplish...

Charles

> -----Original Message-----
> From: Brian Warner [mailto:warner-buildbot at lothar.com]
> Sent: Thursday, June 09, 2005 4:41 PM
> To: Charles Hardin
> Cc: buildbot-devel at lists.sourceforge.net
> Subject: Re: [Buildbot-devel] Perforce Password Patch
> 
> > Doing a buildbot for a project and in our environment found that the
> > following patch was useful since our accounts have to have
passwords...
> 
> If you think this is generally useful, could you put a copy in the
> 'patches'
> tracker on the SourceForge project? (buildbot.sf.net has a link). That
way
> I
> won't forget to incorporate it once I finish these big Scheduler
changes.
> 
> Also, could you make the p4passwd argument optional?
> 
> Hm, and if there were a reasonable way to make a unit test for this,
> that'd
> be wonderful..
> 
> thanks,
>  -Brian