[Buildbot-devel] p4poller fix

Brian Warner warner-buildbot at lothar.com
Wed Jul 6 20:34:02 UTC 2005


> I noticed that p4poller doesn't handle filenames with spaces.  Here's a patch

Thanks!

I think this is equivalent to the following (slightly cleaner version)..
could you verify it for me? (I don't have a way to test perforce stuff):

--- changes/p4poller.py	17 May 2005 10:14:09 -0000	1.4
+++ changes/p4poller.py	21 Jun 2005 22:10:43 -0000
@@ -109,7 +110,7 @@
         while lines:
             line = lines.pop(0).strip()
             if not line: continue
-            files.append(line.split(' ')[1])
+            files.append(line.split(' ',1)[1])
         change['files'] = files
         return change

Let me know.. if so I'll commit it.

thanks,
 -Brian




More information about the devel mailing list