[Buildbot-devel] master port not idiot-proof

Brian Warner warner-buildbot at lothar.com
Fri Dec 23 07:36:11 UTC 2005


> so when you try to run a buildbot client and you enter the HTTP port
> where the PB port is supposed to go, it kinda silently hangs, no
> messages on the client side, no messages on the server side, and if it
> ever times out, well, it was longer than I was willing to wait.

This is a flaw in oldpb. It results from an unfortunate interaction between
the two: the oldpb client is waiting for the server end to say something,
while the HTTP server is waiting for the client to say something.

Fixing this was one of the design criteria for newpb: "make it fail sensibly
and quickly when faced with an HTTP server". To accomplish this, newpb uses
the same client-sends-first logic that HTTP does.

I'm not sure if there is any good way to resolve it with oldpb.. maybe a
client-side timeout on the connection, but set to how long? Maybe 10 seconds?

 -Brian




More information about the devel mailing list