[Buildbot-devel] big custom logs horking the status web server?

[Brian Warner]

Here's a patch to implement the better approach I mentioned. This (plus a
test case, once I figure out the large-logs-hang-with-Twisted-1.3.0 problem)
will be in the next release.

cheers,
 -Brian


* looking for arch at buildbot.sf.net--2004/buildbot--dev--0--patch-265 to compare with
* comparing to arch at buildbot.sf.net--2004/buildbot--dev--0--patch-265: ....... done.

* modified files

--- orig/buildbot/process/step.py
+++ mod/buildbot/process/step.py
@@ -621,7 +621,9 @@
     def addCompleteLog(self, name, text):
         log.msg("addCompleteLog(%s)" % name)
         loog = self.step_status.addLog(name)
-        loog.addStdout(text)
+        size = loog.chunkSize
+        for start in range(0, len(text), size):
+            loog.addStdout(text[start:start+size])
         loog.finish()
 
     def addHTMLLog(self, name, html):


--- orig/buildbot/status/builder.py
+++ mod/buildbot/status/builder.py
@@ -363,7 +365,7 @@
             self.merge()
         self.runEntries.append((channel, text))
         self.runLength += len(text)
-        if self.runLength > self.chunkSize:
+        if self.runLength >= self.chunkSize:
             self.merge()
 
         for w in self.watchers: