[Buildbot-devel] win32 create process info

Brian Warner warner-buildbot at lothar.com
Tue Apr 26 21:29:46 UTC 2005


> From very rudimentary experimentation it looks like both of these do the same
> thing:
> cmd /c "dir c:\windows"
> cmd /c dir c:\windows
> 
> However, this (executed from bash) does something completely different:
> ~    cory ~% cmd /c 'dir "c:\documents and settings"'
> ~    The filename, directory name, or volume label syntax is incorrect.
> 
> It looks like it's tokenizing this command line without removing the quotes.
> Better use shlex.split() on self.command.

Gah, that's the sort of thing I'd like to avoid. It should be possible for a
BuildStep to start a RemoteShellCommand with a list of arguments that are not
processed further. That seems like the only sane way to get spaces into an
argument.

I suppose that the rule can just be "if you've got windows buildslaves,
either provide the command as one big string, or don't include any spaces in
your arguments". Broken, but better than a buildslave that can't run standard
(installed) tools.

I'll commit the change and see what happens.

thanks,
 -Brian




More information about the devel mailing list