[Buildbot-devel] test_slavecommand

[Nick Trout]

After some fiddling around I got the tests for slavecommand to work
under win32. in SlaveCommandTestCase I had to concatenate the outputs of
stdout and stderr to compare them against the expected results. It looks
like posix is outputting everything to stdout, whereas win32 is
outputting to stdout and stderr. This causes the tests to fail because
you only compare against stdout (assuming the tests pass!).

I changed checkStdout(...) to (and the calling functions accordingly):

    def checkOutput(self, sources, expected):
        expected = expected.replace("\n", "\r\n", 1000) # PTY does this
        got = "".join([self.getfile(src) for src in sources])
        self.assertEquals(got, expected)

I'll attach the file to a bug report. I don't know if this is a bug but
it'll let you look at the file.

I still haven't got the win32 version working yet. I'm running off BB
CVS (on win2k).

Nick