[Buildbot-devel] buildbot-0.6.2: need to change master.cfg?

[Justin Mason]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Justin Mason writes:
> BTW, I'm seeing these errors using my 0.6.1 master.cfg with 0.6.2:

fixed, patch below.  However, I still get errors from all the slaves;
is it necessary to recreate slave directories every time buildbot
is upgraded?   (I'm about to try deleting and recreating one now.)

the traceback is:

2004/12/13 12:48 PST [-] Log opened.
2004/12/13 12:48 PST [-] twistd 1.3.0rc1 (/usr/bin/python2.2 2.2.2) starting up
2004/12/13 12:48 PST [-] reactor class: twisted.internet.default.SelectReactor
2004/12/13 12:48 PST [-] Loading buildbot.tap...
2004/12/13 12:48 PST [-] Loaded.
2004/12/13 12:48 PST [-] Traceback (most recent call last):
2004/12/13 12:48 PST [-]   File "/usr/bin/twistd", line 37, in ?
2004/12/13 12:48 PST [-]     run()
2004/12/13 12:48 PST [-]   File "/usr/lib/python2.2/site-packages/twisted/scripts/twistd.py", line 184, in run
2004/12/13 12:48 PST [-]     app.run(runApp, ServerOptions)
2004/12/13 12:48 PST [-]   File "/usr/lib/python2.2/site-packages/twisted/application/app.py", line 205, in run
2004/12/13 12:48 PST [-]     runApp(config)
2004/12/13 12:48 PST [-]   File "/usr/lib/python2.2/site-packages/twisted/scripts/twistd.py", line 175, in runApp
2004/12/13 12:48 PST [-]     startApplication(config, application)
2004/12/13 12:48 PST [-]   File "/usr/lib/python2.2/site-packages/twisted/scripts/twistd.py", line 159, in startApplication
2004/12/13 12:48 PST [-]     service.IService(application).privilegedStartService()
2004/12/13 12:48 PST [-]   File "/usr/lib/python2.2/site-packages/twisted/application/service.py", line 205, in privilegedStartService
2004/12/13 12:48 PST [-]     service.privilegedStartService()
2004/12/13 12:48 PST [-]   File "/usr/lib/python2.2/site-packages/twisted/application/service.py", line 204, in privilegedStartService
2004/12/13 12:48 PST [-]     for service in self:
2004/12/13 12:48 PST [-]   File "/usr/lib/python2.2/site-packages/twisted/application/service.py", line 225, in __iter__
2004/12/13 12:48 PST [-]     return iter(self.services)
2004/12/13 12:48 PST [-] AttributeError: BuildSlave instance has no attribute 'services'

- --j.

diff -ru buildbot-0.6.2/buildbot/master.py buildbot-0.6.2jm/buildbot/master.py
- --- buildbot-0.6.2/buildbot/master.py   Sun Dec  5 23:36:34 2004
+++ buildbot-0.6.2jm/buildbot/master.py Mon Dec 13 12:32:38 2004
@@ -798,7 +798,11 @@
         self.checker.addUser("change", "changepw")

         # identify new/old bots
- -        old = self.bots; oldnames = [name for name,pw in old]
+       try:
+            old = self.bots; oldnames = [name for name,pw in old]
+        except AttributeError:
+            oldnames = []
+
         new = bots; newnames = [name for name,pw in new]
         # removeSlave will hang up on the old bot
         [self.botmaster.removeSlave(name)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBvgBwMJF5cimLx9ARAk5JAJ9QXIoNnx0De3IH2/liDcIA/0iZYwCfUS9j
IXP/oG9ZaGEppSI/IGm0qlI=
=hfh6
-----END PGP SIGNATURE-----