[Buildbot-commits] [buildbot/buildbot] 98fe68: test_stop_trigger: reproduce remote_interruptComma...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 98fe6887001ac1632234f0a6ab5a797c864f4e57
      https://github.com/buildbot/buildbot/commit/98fe6887001ac1632234f0a6ab5a797c864f4e57
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-22 (Fri, 22 May 2015)

  Changed paths:
    M master/buildbot/test/integration/test_stop_trigger.py

  Log Message:
  -----------
  test_stop_trigger: reproduce remote_interruptCommand no attribute error

This commit adds a test to reproduce the remote_interruptCommand
no attribute error.


  Commit: 7c9a059f74f77c68399201781fb9d9b9d09c21d5
      https://github.com/buildbot/buildbot/commit/7c9a059f74f77c68399201781fb9d9b9d09c21d5
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-22 (Fri, 22 May 2015)

  Changed paths:
    M master/buildbot/buildslave/protocols/base.py
    M master/buildbot/buildslave/protocols/null.py
    M master/buildbot/buildslave/protocols/pb.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/test/fake/fakeprotocol.py
    M master/buildbot/test/util/protocols.py

  Log Message:
  -----------
  remoteInterruptCommand: add builderName argument

The rpc method can be directed to two type of objects:
- slave.buildslave.base.BotBase, or
- SlaveBuilder, that is contained on the previous object
  inside a dictionary {buildername: SlaveBuilder}.

Currently, the remote interruptCommand rpc is directed
to the slave.buildslave.base.Botbase. However this
object does not have any interruptCommand method,
only the SlaveBuilder has it.

Moreover, the current prototype of the method remoteInterruptCommand
- (commandId, why)
does not permit to find the associated SlaveBuidler to which
the rpc should be directed to.

This commit implements:
- a change of the prototype to the remoteInterruptCommand method
  to add the builderName, i.e (builderName, commandId, why)
- a redirection of the interruptCommand rpc, to the SlaveBuilder.


  Commit: 992e766fcf69201956317cccabe7e21e52039e70
      https://github.com/buildbot/buildbot/commit/992e766fcf69201956317cccabe7e21e52039e70
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-05-22 (Fri, 22 May 2015)

  Changed paths:
    M master/buildbot/buildslave/protocols/base.py
    M master/buildbot/buildslave/protocols/null.py
    M master/buildbot/buildslave/protocols/pb.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/test/fake/fakeprotocol.py
    M master/buildbot/test/integration/test_stop_trigger.py
    M master/buildbot/test/util/protocols.py

  Log Message:
  -----------
  Merge pull request #1678 from yetanotherion/master

test_stop_trigger: fix remote_interruptCommand no attribute error


Compare: https://github.com/buildbot/buildbot/compare/1c1567d5141c...992e766fcf69