[Buildbot-commits] [buildbot/buildbot] 2f4f24: build.py: remove result

Wed May 13 17:16:49 UTC 2015

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 2f4f24e5e11ec6799200ed44754fae6ac13057b6
      https://github.com/buildbot/buildbot/commit/2f4f24e5e11ec6799200ed44754fae6ac13057b6
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/test/unit/test_process_build.py

  Log Message:
  -----------
  build.py: remove result

build.py uses two attributes for the same goal:
results and result.

This commit gets rid of result, to be compatible with
the overall nomenclature of the code.

Note that as the result contains one verdict only,
it seems a wider results -> result renaming
would be appropriate.

Change-Id: I463cd4467d093df939e8274a3101373d0169b8b5
Signed-off-by: Ion Alberdi <ialberdi at intel.com>

  Commit: f5904f07cac9ae8f007366c4124a0ef66b08915a
      https://github.com/buildbot/buildbot/commit/f5904f07cac9ae8f007366c4124a0ef66b08915a
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M master/buildbot/data/builds.py
    M master/buildbot/process/build.py
    M master/buildbot/test/fake/fakedata.py
    M master/buildbot/test/unit/test_data_builds.py

  Log Message:
  -----------
  build.py: split addBuild in addBuild/generateNewBuildEvent

To be able to observe the events related to one build
(by means of the method startConsuming)
before the 'new' build event is triggered, this commit
splits the addBuild method in two.

Change-Id: I6d4ddbcbd02fab6233a3affee7dfba5bf7b22ec0
Signed-off-by: Ion Alberdi <ialberdi at intel.com>

  Commit: 751dc47434eb26c3f8d2cc0050a8341df53a0fea
      https://github.com/buildbot/buildbot/commit/751dc47434eb26c3f8d2cc0050a8341df53a0fea
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M master/buildbot/data/buildrequests.py
    M master/buildbot/data/builds.py
    M master/buildbot/process/build.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/test/fake/fakedata.py
    A master/buildbot/test/integration/test_stop_trigger.py
    M master/buildbot/test/util/integration.py

  Log Message:
  -----------
  build: implement stop build

this commit implements the stop of builds
with associated integration tests.

Change-Id: Ie81306b32cacebb1e277b8d3bf785a7ae2ccf2de
Signed-off-by: Ion Alberdi <ialberdi at intel.com>

  Commit: 95b90d7f0881dd4891199b16be9af2242729081b
      https://github.com/buildbot/buildbot/commit/95b90d7f0881dd4891199b16be9af2242729081b
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M master/buildbot/process/buildrequest.py

  Log Message:
  -----------
  buildrequest: remove deprecated cancel

As the stop/cancel works by means of messages sent
to the bus and associated callbacks, this commit
removes the deprecated way of doing so.

Change-Id: Id3480ef1b782762d9967b2a542db87b9e5f96cec
Signed-off-by: Ion Alberdi <ialberdi at intel.com>

  Commit: 2d3f3fe9ec5369094f92a16bdc2606bc30afa0d5
      https://github.com/buildbot/buildbot/commit/2d3f3fe9ec5369094f92a16bdc2606bc30afa0d5
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M www/base/src/app/builders/build/build.controller.coffee
    M www/base/src/app/common/services/buildbot/buildbot.service.coffee

  Log Message:
  -----------
  stop: implement the UI part

This commit adds a stop button in top
of the build page.

Change-Id: I9d95f5cab2e54f250dd0fa1dcb25da8a2ff269c8
Signed-off-by: Ion Alberdi <ialberdi at intel.com>

  Commit: 9fba82a4ad3a5f53d5de601b31e4ed2d527f2244
      https://github.com/buildbot/buildbot/commit/9fba82a4ad3a5f53d5de601b31e4ed2d527f2244
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-12 (Tue, 12 May 2015)

  Changed paths:
    M master/buildbot/process/buildstep.py

  Log Message:
  -----------
  buildstep: fix updateSummary race condition

Stop trigger integration tests, revelead a race
condition. When updateSummary is called
before the step is started, self.stepid is not set
and thus the setStepStateString(self.stepid, ...)
call failed.

This commit fixes that issue.

Change-Id: I725b9a4f791b1063bdac892be9dca27471f4b452
Signed-off-by: Ion Alberdi <ialberdi at intel.com>

  Commit: 07f87e45df1b12f8b69efc32c25cf111b48fa9d2
      https://github.com/buildbot/buildbot/commit/07f87e45df1b12f8b69efc32c25cf111b48fa9d2
  Author: Ion Alberdi <ialberdi at intel.com>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M master/buildbot/data/buildrequests.py

  Log Message:
  -----------
  buildrequests: improve reason computing on cancel

this commit implements two improvements on how
the reason sent via the cancel message is computed:
- setup a default value 'no reason'
- the message is computed once for all messages
  to be sent.

Change-Id: I4738e3f16606890a17c24f2d4eb5dad8b3d16597
Signed-off-by: Ion Alberdi <ialberdi at intel.com>

  Commit: 052fda5af28210db3c86605ffae854d58b0cff0b
      https://github.com/buildbot/buildbot/commit/052fda5af28210db3c86605ffae854d58b0cff0b
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-05-13 (Wed, 13 May 2015)

  Changed paths:
    M master/buildbot/data/buildrequests.py
    M master/buildbot/data/builds.py
    M master/buildbot/process/build.py
    M master/buildbot/process/buildrequest.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/test/fake/fakedata.py
    A master/buildbot/test/integration/test_stop_trigger.py
    M master/buildbot/test/unit/test_data_builds.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/util/integration.py
    M www/base/src/app/builders/build/build.controller.coffee
    M www/base/src/app/common/services/buildbot/buildbot.service.coffee

  Log Message:
  -----------
  Merge pull request #1656 from yetanotherion/master

stop

Compare: https://github.com/buildbot/buildbot/compare/6a5f245ff9b0...052fda5af282