[Buildbot-commits] [buildbot/buildbot] 1f4a3f: Fix sigtermTime race.

GitHub noreply at github.com
Wed Mar 18 18:18:47 UTC 2015


  Branch: refs/heads/eight
  Home:   https://github.com/buildbot/buildbot
  Commit: 1f4a3f3298113b961fd460457be2d522c1350b70
      https://github.com/buildbot/buildbot/commit/1f4a3f3298113b961fd460457be2d522c1350b70
  Author: Tom Prince <tom.prince at ualberta.net>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M slave/buildslave/runprocess.py

  Log Message:
  -----------
  Fix sigtermTime race.

If twisted notices that a process dies between when SIGTERM is sent,
then RunProcess.process.pid will be None, causing checkDead to fail.

In any case, the timer will be leaked, and it will be cancelled after having
been called.


  Commit: 05ada3b50e7289d4662eff8bea81eda419295c6d
      https://github.com/buildbot/buildbot/commit/05ada3b50e7289d4662eff8bea81eda419295c6d
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-03-18 (Wed, 18 Mar 2015)

  Changed paths:
    M slave/buildslave/runprocess.py

  Log Message:
  -----------
  Merge pull request #1604 from tomprince/sigtermTime-race-condition

Fix sigtermTime race.


Compare: https://github.com/buildbot/buildbot/compare/9f558c1d794b...05ada3b50e72


More information about the Commits mailing list