[Buildbot-commits] [buildbot/buildbot] f22871: Don't hardcode the list of modes for SVN checkout

Mon Mar 16 05:01:29 UTC 2015

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: f22871b2d9610cc90bcf3f3dc6a2ff54a6901fc1
      https://github.com/buildbot/buildbot/commit/f22871b2d9610cc90bcf3f3dc6a2ff54a6901fc1
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/svn.py

  Log Message:
  -----------
  Don't hardcode the list of modes for SVN checkout

  Commit: 8ae347573c4ecda3c9e5c777e7c8f41bb6f3dd95
      https://github.com/buildbot/buildbot/commit/8ae347573c4ecda3c9e5c777e7c8f41bb6f3dd95
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/base.py

  Log Message:
  -----------
  Add methods for querying "attribute groups"

An "attribute group" is a group of attributes with a common name prefix.
The "mode" attribute group contains two members: full and incremental.
The full and incremental names must have the same "mode_" prefix, making
the method names "mode_full" and "mode_incremental".

The _hasAttrGroupMember and _getAttrGroupMember are the attribute group
equivalents of hasattr and getattr. The _listAttrGroupMembers exists so
options can be returned in error messages to help people know what the
valid options are without checking the docs or source.

  Commit: f6d39469b9879a73b70f14bc66fc835517e7bec1
      https://github.com/buildbot/buildbot/commit/f6d39469b9879a73b70f14bc66fc835517e7bec1
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_base_Source.py

  Log Message:
  -----------
  Add attribute group tests

  Commit: b65a5208e67ff78604f54a0cd5fafb3742ccd911
      https://github.com/buildbot/buildbot/commit/b65a5208e67ff78604f54a0cd5fafb3742ccd911
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/svn.py

  Log Message:
  -----------
  Use new attribute group methods in SVN step

  Commit: e7c1fb71cf50f26d682f4c6fb4e30f548594b069
      https://github.com/buildbot/buildbot/commit/e7c1fb71cf50f26d682f4c6fb4e30f548594b069
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/bzr.py

  Log Message:
  -----------
  Convert bzr to use attribute group for 'mode'

  Commit: e035a75be1916e7d9e5768be1bac3fa005f47543
      https://github.com/buildbot/buildbot/commit/e035a75be1916e7d9e5768be1bac3fa005f47543
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/cvs.py

  Log Message:
  -----------
  Convert cvs  to use attribute group for 'mode'

Also added validation of the mode when creating the step. No other
validation was added.

  Commit: b7d47ac0997a5514fb205cb371606dfcb261111d
      https://github.com/buildbot/buildbot/commit/b7d47ac0997a5514fb205cb371606dfcb261111d
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/darcs.py

  Log Message:
  -----------
  Convert darcs to use attribute group for 'mode'

  Commit: ac2f95760b0fd9556a3ca5a27211b4535424cbb9
      https://github.com/buildbot/buildbot/commit/ac2f95760b0fd9556a3ca5a27211b4535424cbb9
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/git.py

  Log Message:
  -----------
  Convert git to use attribute group for 'mode'

  Commit: 1ef67192902a3c0af7ecb9fc2ecd9b0de8696c0f
      https://github.com/buildbot/buildbot/commit/1ef67192902a3c0af7ecb9fc2ecd9b0de8696c0f
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Convert mercurial to use attribute group for 'mode'

  Commit: ebd96d87fd73921e9267b2a4938ef2a76647fbb1
      https://github.com/buildbot/buildbot/commit/ebd96d87fd73921e9267b2a4938ef2a76647fbb1
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/mtn.py

  Log Message:
  -----------
  Convert mtn to use attribute group for 'mode'

  Commit: 069991a8db7f46e030b450386a071a7f8ff41976
      https://github.com/buildbot/buildbot/commit/069991a8db7f46e030b450386a071a7f8ff41976
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-02 (Mon, 02 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/p4.py

  Log Message:
  -----------
  Partially convert p4 to use attribute group for 'mode'

The check if self.mode is in possible_modes can be changed but there's
also a check if it's a renderable. That's different from everything else
so I am skipping it until the history is better understood.

  Commit: 0cd61681322d7ac2388ef10328619d5c8ebae957
      https://github.com/buildbot/buildbot/commit/0cd61681322d7ac2388ef10328619d5c8ebae957
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-05 (Thu, 05 Mar 2015)

  Changed paths:
    M master/buildbot/test/integration/test_configs.py

  Log Message:
  -----------
  Change integration test to use method="copy" instead of mode="copy"

Per the documentation, mode is defined to only accept "full" or
"incremental". The method parameter is what accepts "copy". It is an old
commit that set the integration test to use mode="copy" and the CVS step
does little checking.

  Commit: f01d9281f8b0cf43c9a92270917141e2a9914c4a
      https://github.com/buildbot/buildbot/commit/f01d9281f8b0cf43c9a92270917141e2a9914c4a
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-06 (Fri, 06 Mar 2015)

  Changed paths:
    M master/buildbot/test/unit/test_steps_source_base_Source.py

  Log Message:
  -----------
  Add blank lines to comply with PEP8

  Commit: 7bbbb8081032fd78fdea23f284e07341274fbe50
      https://github.com/buildbot/buildbot/commit/7bbbb8081032fd78fdea23f284e07341274fbe50
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-06 (Fri, 06 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/svn.py

  Log Message:
  -----------
  Remove variable left over from first commit

  Commit: 45577eec2b91210b0621bb34720c2deca2b7e5fb
      https://github.com/buildbot/buildbot/commit/45577eec2b91210b0621bb34720c2deca2b7e5fb
  Author: Sean Kelly <code at katron.org>
  Date:   2015-03-09 (Mon, 09 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/base.py

  Log Message:
  -----------
  `m` isn't used at all; use `ismethod` directly

  Commit: 7c7313df0c283afb086c43c162a3da0044fa3384
      https://github.com/buildbot/buildbot/commit/7c7313df0c283afb086c43c162a3da0044fa3384
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-03-16 (Mon, 16 Mar 2015)

  Changed paths:
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/bzr.py
    M master/buildbot/steps/source/cvs.py
    M master/buildbot/steps/source/darcs.py
    M master/buildbot/steps/source/git.py
    M master/buildbot/steps/source/mercurial.py
    M master/buildbot/steps/source/mtn.py
    M master/buildbot/steps/source/p4.py
    M master/buildbot/steps/source/svn.py
    M master/buildbot/test/integration/test_configs.py
    M master/buildbot/test/unit/test_steps_source_base_Source.py

  Log Message:
  -----------
  Merge pull request #1573 from seankelly/dynamic-mode

Make source checkout steps not rely on hard-coded list of modes

Compare: https://github.com/buildbot/buildbot/compare/6dd2ddfca0ec...7c7313df0c28