[Buildbot-commits] [buildbot/buildbot] fe96d8: Fix GerritStatusPush 'startCB' not work

[GitHub]

  Branch: refs/heads/eight
  Home:   https://github.com/buildbot/buildbot
  Commit: fe96d8daa283e9725d1096214f2b1cdbbbf09d4c
      https://github.com/buildbot/buildbot/commit/fe96d8daa283e9725d1096214f2b1cdbbbf09d4c
  Author: stanzgy <stanzgy at gmail.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M master/buildbot/status/status_gerrit.py
    M master/buildbot/test/unit/test_status_gerrit.py

  Log Message:
  -----------
  Fix GerritStatusPush 'startCB' not work

Fix GerritStatusPush 'startCB' not work with Gerrit+Git.
GerritStatusPush 'startCB' triggers before buildsteps start. But the condition
'startCB' decide to send code reviews is the property 'gerrit_branch' which is
set during the buildbot.steps.source.gerrit.Gerrit buildstep. So use property
'event.change.id' instead of 'gerrit_branch' to verify Gerrit source to ensure
'startCB' works properly.

The property 'got_revision' here also has same problem when 'startCB' triggers.


  Commit: 2cfefa0f0f926ac1cad65f0dfa7284d2dfe3bc1a
      https://github.com/buildbot/buildbot/commit/2cfefa0f0f926ac1cad65f0dfa7284d2dfe3bc1a
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-03-10 (Tue, 10 Mar 2015)

  Changed paths:
    M master/buildbot/status/status_gerrit.py
    M master/buildbot/test/unit/test_status_gerrit.py

  Log Message:
  -----------
  Merge pull request #1575 from stanzgy/eight

Fix GerritStatusPush 'startCB' not work


Compare: https://github.com/buildbot/buildbot/compare/d4bdf212b7b5...2cfefa0f0f92