[Buildbot-commits] [buildbot/buildbot] b0245a: Enhance stop button behavior

GitHub noreply at github.com
Thu Jun 11 16:17:15 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: b0245a3cd920a3150605e51003349d0feffd44e4
      https://github.com/buildbot/buildbot/commit/b0245a3cd920a3150605e51003349d0feffd44e4
  Author: Sebastien Savrimoutou <sebastien.savrimoutou at intel.com>
  Date:   2015-06-10 (Wed, 10 Jun 2015)

  Changed paths:
    M www/base/src/app/builders/build/build.controller.coffee

  Log Message:
  -----------
  Enhance stop button behavior

Currently the stop button was still visible even if
the build was finished.

This patch suggest a new behavior:
- Remove the button from the contextual menu when the build is finished
- Rename the caption to 'Stop on going' once pressed

Signed-off-by: Sebastien Savrimoutou <sebastien.savrimoutou at intel.com>


  Commit: df4a6345cf9cae9b893436979f91671de64f70ee
      https://github.com/buildbot/buildbot/commit/df4a6345cf9cae9b893436979f91671de64f70ee
  Author: Sebastien Fusilier <sebastien.fusilier at intel.com>
  Date:   2015-06-10 (Wed, 10 Jun 2015)

  Changed paths:
    M www/base/src/app/builders/build/build.controller.coffee

  Log Message:
  -----------
  Review rework

- Rename 'is-stopped' to 'is_stopping'
- Change 'Stop on going...' style

Signed-off-by: Sebastien Fusilier <sebastien.fusilier at intel.com>


  Commit: 6f32eccefafd1448f405826520d42dca37ca603d
      https://github.com/buildbot/buildbot/commit/6f32eccefafd1448f405826520d42dca37ca603d
  Author: Sebastien Fusilier <sebastien.fusilier at intel.com>
  Date:   2015-06-11 (Thu, 11 Jun 2015)

  Changed paths:
    M www/base/src/app/builders/build/build.controller.coffee

  Log Message:
  -----------
  Rename "Stop on going..." to "Stopping..."

Signed-off-by: Sebastien Fusilier <sebastien.fusilier at intel.com>


  Commit: af897413f58a7a440d1385d396c845e9fb3b4d8a
      https://github.com/buildbot/buildbot/commit/af897413f58a7a440d1385d396c845e9fb3b4d8a
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-06-11 (Thu, 11 Jun 2015)

  Changed paths:
    M www/base/src/app/builders/build/build.controller.coffee

  Log Message:
  -----------
  Merge pull request #1714 from ssavrim/hide_stop_button

Enhance stop button behavior


Compare: https://github.com/buildbot/buildbot/compare/135314575866...af897413f58a


More information about the Commits mailing list