[Buildbot-commits] [buildbot/buildbot] bfd8ec: Parse value-less items in .gitconfig as equal to `...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: bfd8eced0b78c1e3e2f2f8808a52def147f46755
      https://github.com/buildbot/buildbot/commit/bfd8eced0b78c1e3e2f2f8808a52def147f46755
  Author: Olivier Favre <olivier at yakaz.com>
  Date:   2015-02-18 (Wed, 18 Feb 2015)

  Changed paths:
    M master/buildbot/clients/tryclient.py

  Log Message:
  -----------
  Parse value-less items in .gitconfig as equal to `"true"`

Solves a problem when sending the patch when using buildbot try on a
git-managed project.

    Unhandled Error
    Traceback (most recent call last):
      File "/usr/lib/python2.7/dist-packages/twisted/internet/_baseprocess.py", line 60, in maybeCallProcessEnded
  proto.processEnded(Failure(reason))
      File "/usr/lib/python2.7/dist-packages/twisted/internet/utils.py", line 159, in processEnded
  self.deferred.callback((out, err, code))
      File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 368, in callback
  self._startRunCallbacks(result)
      File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
  self._runCallbacks()
    --- <exception caught here> ---
      File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 551, in _runCallbacks
  current.result = callback(current.result, *args, **kw)
      File "/usr/lib/python2.7/dist-packages/buildbot/clients/tryclient.py", line 306, in parseConfig
  self.config[parts[0]] = parts[1]
    exceptions.IndexError: list index out of range

    (The line numbers may not match the current master.)

As to why defaulting to `"true"`, see the following excerpt of the
`git-config(1)` manpage:

    CONFIGURATION FILE
     [...]
  Syntax
     [...]
      All the other lines (and the remainder of the line after
     the section header) are recognized as setting variables, in
     the form name = value. If there is no equal sign on the
     line, the entire line is taken as name and the variable is
     recognized as boolean "true". The variable names are


  Commit: 74f59698d95e3c175065e5c1a6844f9832f78d68
      https://github.com/buildbot/buildbot/commit/74f59698d95e3c175065e5c1a6844f9832f78d68
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-02-23 (Mon, 23 Feb 2015)

  Changed paths:
    M master/buildbot/clients/tryclient.py

  Log Message:
  -----------
  Merge pull request #1549 from yakaz/fix-gitconfig-novalue

Parse value-less items in .gitconfig as equal to `"true"`


Compare: https://github.com/buildbot/buildbot/compare/d2ed981d1a79...74f59698d95e