[Buildbot-commits] [buildbot/buildbot] 4aeb65: Fix aliasing of codebase_ss

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 4aeb65df985e3df62e3e5532d39b482a9c8f3b35
      https://github.com/buildbot/buildbot/commit/4aeb65df985e3df62e3e5532d39b482a9c8f3b35
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2015-02-08 (Sun, 08 Feb 2015)

  Changed paths:
    M master/buildbot/test/unit/test_db_changes.py

  Log Message:
  -----------
  Fix aliasing of codebase_ss

This variable was being set to {} in addBuild, but as a variable local
to addBuild, not to the test.  Switcihng that to codebase_ss.clear()
fixes the issue by not using assignment.  This patch also makes this
variable a dict of sourcestamps by codebase, rather than a dict of lists
of sourcestamps -- it's invalid to have multiple sourcestamps for the
same codebase.


  Commit: c84fc5ac36954284fbae1b4ba8c4b3a9bdcdeed2
      https://github.com/buildbot/buildbot/commit/c84fc5ac36954284fbae1b4ba8c4b3a9bdcdeed2
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2015-02-08 (Sun, 08 Feb 2015)

  Changed paths:
    M master/buildbot/test/unit/test_db_changes.py

  Log Message:
  -----------
  fix tests to be more specific, correct


  Commit: 526a15df169d6aed08f6cb23b358225e1f2ebd77
      https://github.com/buildbot/buildbot/commit/526a15df169d6aed08f6cb23b358225e1f2ebd77
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2015-02-08 (Sun, 08 Feb 2015)

  Changed paths:
    M master/buildbot/db/changes.py

  Log Message:
  -----------
  remove useless list comprehension


  Commit: 4dfe6672d41630451d6a8447381d0d5f3865f073
      https://github.com/buildbot/buildbot/commit/4dfe6672d41630451d6a8447381d0d5f3865f073
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-02-09 (Mon, 09 Feb 2015)

  Changed paths:
    M master/buildbot/db/changes.py
    M master/buildbot/test/unit/test_db_changes.py

  Log Message:
  -----------
  Merge pull request #1534 from djmitche/bug3191

Fix bogus test for getChangesForBuild


Compare: https://github.com/buildbot/buildbot/compare/fb28207fd268...4dfe6672d416