[Buildbot-commits] [buildbot/buildbot] 0c9c58: Introduce RemoteCommandProxy to the protocol

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 0c9c58dad4830ee4797966be9146653557f84bbd
      https://github.com/buildbot/buildbot/commit/0c9c58dad4830ee4797966be9146653557f84bbd
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M master/buildbot/buildslave/protocols/base.py
    M master/buildbot/buildslave/protocols/pb.py
    M master/buildbot/process/remotecommand.py

  Log Message:
  -----------
  Introduce RemoteCommandProxy to the protocol

RemoteCommand actually has 2 remote methods: remote_update() and remote_complete()

We create a proxy so those methods so that the base protocol does not depend on pb anymore

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: af0d91a1d91c80213d1d606ce1feec392625acb0
      https://github.com/buildbot/buildbot/commit/af0d91a1d91c80213d1d606ce1feec392625acb0
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M master/buildbot/buildslave/protocols/base.py
    A master/buildbot/process/remotetransfer.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/cvs.py
    M master/buildbot/steps/source/darcs.py
    M master/buildbot/steps/transfer.py
    M master/buildbot/test/unit/test_buildslave_protocols_pb.py
    A master/buildbot/test/unit/test_process_remotetransfer.py
    M master/buildbot/test/unit/test_steps_shell.py
    M master/buildbot/test/unit/test_steps_source_bzr.py
    M master/buildbot/test/unit/test_steps_source_cvs.py
    M master/buildbot/test/unit/test_steps_source_darcs.py
    M master/buildbot/test/unit/test_steps_source_git.py
    M master/buildbot/test/unit/test_steps_source_mercurial.py
    M master/buildbot/test/unit/test_steps_source_mtn.py
    M master/buildbot/test/unit/test_steps_source_svn.py
    M master/buildbot/test/unit/test_steps_transfer.py
    M slave/buildslave/commands/transfer.py

  Log Message:
  -----------
  refactor steps.transfer._File[Writer|Reader]

Too much steps were using this private api
We make a real API, and put it in the protocol

This is a first step into not leaking pb.Reference in the protocol

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 8c896a8bc7dbd2d17054071f5d973a9567f3036b
      https://github.com/buildbot/buildbot/commit/8c896a8bc7dbd2d17054071f5d973a9567f3036b
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M master/buildbot/buildslave/protocols/base.py
    M master/buildbot/buildslave/protocols/pb.py
    A master/buildbot/test/integration/test_transfer.py

  Log Message:
  -----------
  add a integration test for the transfer protocol

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: de0f0fc5c7726b7a5e8a6af83e3267ead0de0545
      https://github.com/buildbot/buildbot/commit/de0f0fc5c7726b7a5e8a6af83e3267ead0de0545
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M master/docs/developer/cls-protocols.rst

  Log Message:
  -----------
  documenting

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: fc94ae344c5d539c41934421d4ef2a77235947e1
      https://github.com/buildbot/buildbot/commit/fc94ae344c5d539c41934421d4ef2a77235947e1
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M slave/buildslave/commands/transfer.py

  Log Message:
  -----------
  fix docstring

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: b5521bd5833302e761e297b8a1d52e193e7b3d0e
      https://github.com/buildbot/buildbot/commit/b5521bd5833302e761e297b8a1d52e193e7b3d0e
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M master/buildbot/buildslave/manager.py
    A master/buildbot/buildslave/protocols/null.py
    M master/buildbot/buildslave/protocols/pb.py
    M master/buildbot/config.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/test/integration/test_transfer.py
    M master/buildbot/test/util/integration.py
    A slave/buildslave/base.py
    M slave/buildslave/bot.py
    A slave/buildslave/null.py
    A slave/buildslave/pb.py
    M slave/buildslave/test/unit/test_bot.py

  Log Message:
  -----------
  add 'null' protocol

null protocol is the simplest, as it does not go to the wire, made for those who want their slave in the same process as their master


  Commit: 92c3cf25d3219c01749e1163952d50ee8cea7768
      https://github.com/buildbot/buildbot/commit/92c3cf25d3219c01749e1163952d50ee8cea7768
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M master/buildbot/test/unit/test_buildslave_protocols_pb.py
    M master/buildbot/test/unit/test_steps_slave.py
    M master/docs/developer/cls-protocols.rst
    M slave/buildslave/test/unit/test_bot.py

  Log Message:
  -----------
  fix unit tests

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 60a5917ee2354a55c7e5b932d363c4a59e44d241
      https://github.com/buildbot/buildbot/commit/60a5917ee2354a55c7e5b932d363c4a59e44d241
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2015-02-06 (Fri, 06 Feb 2015)

  Changed paths:
    M master/buildbot/buildslave/protocols/base.py
    M master/buildbot/buildslave/protocols/null.py
    M master/buildbot/buildslave/protocols/pb.py
    M master/docs/developer/cls-protocols.rst

  Log Message:
  -----------
  clean protocol so that proxy are fully implemented by protocol

First implementation was arguabily too much pb oriented
Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 1c58f91bcbb9a5be312460abb0e25ffcfd2eff3b
      https://github.com/buildbot/buildbot/commit/1c58f91bcbb9a5be312460abb0e25ffcfd2eff3b
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2015-02-09 (Mon, 09 Feb 2015)

  Changed paths:
    M master/buildbot/buildslave/manager.py
    M master/buildbot/buildslave/protocols/base.py
    A master/buildbot/buildslave/protocols/null.py
    M master/buildbot/buildslave/protocols/pb.py
    M master/buildbot/config.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/remotecommand.py
    A master/buildbot/process/remotetransfer.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/cvs.py
    M master/buildbot/steps/source/darcs.py
    M master/buildbot/steps/transfer.py
    A master/buildbot/test/integration/test_transfer.py
    M master/buildbot/test/unit/test_buildslave_protocols_pb.py
    A master/buildbot/test/unit/test_process_remotetransfer.py
    M master/buildbot/test/unit/test_steps_shell.py
    M master/buildbot/test/unit/test_steps_slave.py
    M master/buildbot/test/unit/test_steps_source_bzr.py
    M master/buildbot/test/unit/test_steps_source_cvs.py
    M master/buildbot/test/unit/test_steps_source_darcs.py
    M master/buildbot/test/unit/test_steps_source_git.py
    M master/buildbot/test/unit/test_steps_source_mercurial.py
    M master/buildbot/test/unit/test_steps_source_mtn.py
    M master/buildbot/test/unit/test_steps_source_svn.py
    M master/buildbot/test/unit/test_steps_transfer.py
    M master/buildbot/test/util/integration.py
    M master/docs/developer/cls-protocols.rst
    A slave/buildslave/base.py
    M slave/buildslave/bot.py
    M slave/buildslave/commands/transfer.py
    A slave/buildslave/null.py
    A slave/buildslave/pb.py
    M slave/buildslave/test/unit/test_bot.py

  Log Message:
  -----------
  Merge pull request #1513 from tardyp/slave-proto

Slave proto: introduce proxies for RemoteCommand, FileWriter and FileReader


Compare: https://github.com/buildbot/buildbot/compare/cfdcf735742d...1c58f91bcbb9