[Buildbot-commits] [buildbot/buildbot] d73354: Fix: Instead of pull everything should it be pull ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: d73354aa1215fe36465d225aafb8fabdcd0ab2d3
      https://github.com/buildbot/buildbot/commit/d73354aa1215fe36465d225aafb8fabdcd0ab2d3
  Author: Maria Marcano <mariangemarcano at gmail.com>
  Date:   2015-07-29 (Wed, 29 Jul 2015)

  Changed paths:
    M master/buildbot/steps/source/mercurial.py
    M master/buildbot/test/unit/test_steps_source_mercurial.py

  Log Message:
  -----------
  Fix: Instead of pull everything should it be pull --rev (branch or rev-hash), hg pull (everything) will create a problem with any branch that has multiple heads (which is valid workflow in Mercurial). Depending on whether you pull a specific revision first, then pull everything, or pull everything first and then get a specific revision, the 'most recently changed head' can be different on the branch, and that can lead to inconsistent results between buildslaves.

Command tested on a katana buildmaster.


  Commit: ca00f9c5fca15e02fe4b5e45535d05057f88111c
      https://github.com/buildbot/buildbot/commit/ca00f9c5fca15e02fe4b5e45535d05057f88111c
  Author: Pierre Tardy <tardyp at gmail.com>
  Date:   2015-08-02 (Sun, 02 Aug 2015)

  Changed paths:
    M master/buildbot/steps/source/mercurial.py
    M master/buildbot/test/unit/test_steps_source_mercurial.py

  Log Message:
  -----------
  Merge pull request #1794 from Unity-Technologies/master

Fix: Instead of pull everything should it be pull --rev (branch or rev)


Compare: https://github.com/buildbot/buildbot/compare/5e5173e6267d...ca00f9c5fca1