[Buildbot-commits] [buildbot/buildbot] 61b044: - use builderid as a foreign key instead of using...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 61b044f924e9563b37bf84de1b5380855954a661
      https://github.com/buildbot/buildbot/commit/61b044f924e9563b37bf84de1b5380855954a661
  Author: Xavier Delannoy <xdelannoy at cloudmark.com>
  Date:   2014-10-01 (Wed, 01 Oct 2014)

  Changed paths:
    M master/buildbot/data/buildrequests.py
    M master/buildbot/data/buildsets.py
    M master/buildbot/db/buildrequests.py
    M master/buildbot/db/buildsets.py
    A master/buildbot/db/migrate/versions/037_buildrequests_builderid.py
    M master/buildbot/db/model.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/builder.py
    M master/buildbot/process/buildrequest.py
    M master/buildbot/process/buildrequestdistributor.py
    M master/buildbot/schedulers/base.py
    M master/buildbot/test/fake/fakedata.py
    M master/buildbot/test/fake/fakedb.py
    M master/buildbot/test/integration/test_custom_buildstep.py
    M master/buildbot/test/unit/test_data_buildrequests.py
    M master/buildbot/test/unit/test_data_buildsets.py
    M master/buildbot/test/unit/test_data_connector.py
    M master/buildbot/test/unit/test_db_buildrequests.py
    M master/buildbot/test/unit/test_db_builds.py
    M master/buildbot/test/unit/test_db_buildsets.py
    M master/buildbot/test/unit/test_db_logs.py
    M master/buildbot/test/unit/test_db_steps.py
    M master/buildbot/test/unit/test_process_builder.py
    M master/buildbot/test/unit/test_process_buildrequest.py
    M master/buildbot/test/unit/test_process_buildrequestdistributor.py
    M master/buildbot/test/unit/test_schedulers_base.py
    M master/buildbot/test/unit/test_schedulers_timed_NightlyBase.py
    M master/buildbot/test/unit/test_schedulers_timed_Periodic.py
    M master/buildbot/test/unit/test_schedulers_triggerable.py
    M master/buildbot/test/unit/test_status_buildset.py
    M master/buildbot/test/unit/test_status_gerrit.py
    M master/buildbot/test/unit/test_status_mail.py
    M master/buildbot/test/unit/test_steps_trigger.py
    M master/buildbot/test/util/scheduler.py
    M master/docs/developer/rtype-buildrequest.rst

  Log Message:
  -----------
   - use builderid as a foreign key instead of using buildername for the table buildrequests
 - addbuilset take a list of buildersID
 - check signatures for the BaseScheduler?'s addBuildsetForXxx methods


  Commit: 781513cfe0612112d02a358f5a7e3dec0fa1ee34
      https://github.com/buildbot/buildbot/commit/781513cfe0612112d02a358f5a7e3dec0fa1ee34
  Author: Xavier Delannoy <xdelannoy at cloudmark.com>
  Date:   2014-10-01 (Wed, 01 Oct 2014)

  Changed paths:
    M master/buildbot/process/botmaster.py
    M master/buildbot/status/master.py

  Log Message:
  -----------
  Add @defer.inlineCallbacks to br_consumer_cb and buildRequestAdded
I think this is needed since a12242da69e76f34cc45523c5a928b19e676d3ff. Dustin, do you confirm ?


  Commit: 3d228e634e1dbdd302047a40aa66add64c778e8b
      https://github.com/buildbot/buildbot/commit/3d228e634e1dbdd302047a40aa66add64c778e8b
  Author: Xavier Delannoy <xdelannoy at cloudmark.com>
  Date:   2014-10-01 (Wed, 01 Oct 2014)

  Changed paths:
    M master/buildbot/status/master.py

  Log Message:
  -----------
  Fix: master/buildbot/status/master.py:423: import 'builder' from line 25 shadowed by loop variable


  Commit: d30e24ab5c6d386677516c5e62adfc957a2e6392
      https://github.com/buildbot/buildbot/commit/d30e24ab5c6d386677516c5e62adfc957a2e6392
  Author: delanne <xavier.delannoy at gmail.com>
  Date:   2014-10-07 (Tue, 07 Oct 2014)

  Changed paths:
    M master/buildbot/data/buildrequests.py
    M master/buildbot/data/buildsets.py
    M master/buildbot/db/buildsets.py
    M master/buildbot/db/migrate/versions/037_buildrequests_builderid.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/test/unit/test_steps_trigger.py
    M master/buildbot/test/util/scheduler.py
    M master/docs/developer/database.rst
    M master/docs/developer/rtype-buildset.rst

  Log Message:
  -----------
   - improve master/db/migrate/versions/037_buildrequests_builderid.py as dustin suggested
 - various minor fix
 - Done:
   - DB API changes reflected in the doc
   - DATA API changes reflected in the doc
   - DATA API for buildrequest's dropping /builders/i:buildername/buildrequests or not (code drops, path still in place)
   - DATA API changes need to be reflected in the FakeData API
   - trigger steps now gets {builderid:buidrequestid} back from the sched.trigger call
   - Try Schedulers's RemoteBuildSetStatus.getBuildRequest should return builder names but returns builder ids
 - todo:
   - SchedulerMixin._addBuildsetReturnValue returns buildernames, but should return builderids
   - BuilderStatus.getPendingBuildRequestStatuses calls db.getBuildRequests (... buildername=...". It's Ok to just assert 0 in this method.
     The whole class will go away soon. Just don't leave it subtly broken


  Commit: d9373fa69752bb36b6c01b082dbeabd83cc88eeb
      https://github.com/buildbot/buildbot/commit/d9373fa69752bb36b6c01b082dbeabd83cc88eeb
  Author: delanne <xavier.delannoy at gmail.com>
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
    M .travis.yml
    M master/buildbot/buildslave/openstack.py
    M master/buildbot/changes/gerritchangesource.py
    M master/buildbot/data/logs.py
    M master/buildbot/interfaces.py
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/status/__init__.py
    M master/buildbot/status/build.py
    R master/buildbot/status/buildstep.py
    R master/buildbot/status/logfile.py
    M master/buildbot/steps/http.py
    M master/buildbot/steps/maxq.py
    M master/buildbot/steps/package/deb/pbuilder.py
    M master/buildbot/steps/python_twisted.py
    M master/buildbot/steps/shell.py
    M master/buildbot/steps/shellsequence.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/base.py
    M master/buildbot/steps/source/repo.py
    M master/buildbot/steps/subunit.py
    M master/buildbot/steps/transfer.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/fake/fakedata.py
    M master/buildbot/test/fake/logfile.py
    M master/buildbot/test/fake/openstack.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/integration/test_custom_buildstep.py
    M master/buildbot/test/regressions/test_oldpaths.py
    M master/buildbot/test/regressions/test_shell_command_properties.py
    M master/buildbot/test/regressions/test_unpickling.py
    M master/buildbot/test/unit/test_buildslave_openstack.py
    M master/buildbot/test/unit/test_changes_gerritchangesource.py
    M master/buildbot/test/unit/test_process_build.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/unit/test_process_remotecommand.py
    R master/buildbot/test/unit/test_status_buildstep.py
    R master/buildbot/test/unit/test_status_logfile.py
    M master/buildbot/test/unit/test_steps_http.py
    M master/buildbot/test/unit/test_steps_master.py
    M master/buildbot/test/unit/test_steps_maxq.py
    M master/buildbot/test/unit/test_steps_mswin.py
    M master/buildbot/test/unit/test_steps_package_deb_lintian.py
    M master/buildbot/test/unit/test_steps_package_deb_pbuilder.py
    M master/buildbot/test/unit/test_steps_package_rpm_mock.py
    M master/buildbot/test/unit/test_steps_package_rpm_rpmbuild.py
    M master/buildbot/test/unit/test_steps_package_rpm_rpmlint.py
    M master/buildbot/test/unit/test_steps_python.py
    M master/buildbot/test/unit/test_steps_python_twisted.py
    M master/buildbot/test/unit/test_steps_shell.py
    M master/buildbot/test/unit/test_steps_shellsequence.py
    M master/buildbot/test/unit/test_steps_slave.py
    M master/buildbot/test/unit/test_steps_source_bzr.py
    M master/buildbot/test/unit/test_steps_source_cvs.py
    M master/buildbot/test/unit/test_steps_source_darcs.py
    M master/buildbot/test/unit/test_steps_source_gerrit.py
    M master/buildbot/test/unit/test_steps_source_git.py
    M master/buildbot/test/unit/test_steps_source_mercurial.py
    M master/buildbot/test/unit/test_steps_source_mtn.py
    M master/buildbot/test/unit/test_steps_source_p4.py
    M master/buildbot/test/unit/test_steps_source_repo.py
    M master/buildbot/test/unit/test_steps_source_svn.py
    M master/buildbot/test/unit/test_steps_subunit.py
    M master/buildbot/test/unit/test_steps_transfer.py
    M master/buildbot/test/unit/test_steps_trigger.py
    M master/buildbot/test/unit/test_steps_vstudio.py
    M master/buildbot/test/unit/test_util.py
    M master/buildbot/test/util/steps.py
    M master/buildbot/util/__init__.py
    M master/buildbot/util/pickle.py
    M master/buildbot/www/rest.py
    M master/buildbot/www/sse.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/developer/utils.rst
    M master/docs/manual/cfg-buildslaves-openstack.rst
    M master/docs/relnotes/index.rst
    M www/base/src/app/builders/build/build.controller.coffee
    M www/base/src/app/builders/builder/builder.controller.coffee
    M www/base/src/app/builders/buildrequest/buildrequest.route.coffee
    M www/base/src/app/builders/log/log.controller.coffee
    M www/base/src/app/builders/log/log.tpl.jade
    M www/base/src/app/builders/log/logviewer/logviewer.directive.coffee
    A www/base/src/app/builders/log/logviewer/logviewer.less
    M www/base/src/app/builders/log/logviewer/logviewer.tpl.jade
    M www/base/src/app/builders/step/step.controller.coffee
    M www/base/src/app/builders/step/step.tpl.jade
    M www/base/src/app/common/directives/buildsummary/buildsummary.directive.coffee
    M www/base/src/app/common/directives/buildsummary/buildsummary.tpl.jade
    M www/base/src/app/common/directives/rawdata/rawdata.tpl.jade
    M www/base/src/app/common/services/mq/mq.service.coffee
    M www/base/src/app/common/services/mq/mq.service.spec.coffee
    M www/base/src/styles/animations.less
    M www/base/src/styles/styles.less

  Log Message:
  -----------
  Merge branch 'master' into trac2621_2658

Conflicts:
	master/buildbot/test/unit/test_steps_trigger.py


  Commit: 2043a4c97c0ba098148fa4a8c616ffc6b615b1aa
      https://github.com/buildbot/buildbot/commit/2043a4c97c0ba098148fa4a8c616ffc6b615b1aa
  Author: delanne <xavier.delannoy at gmail.com>
  Date:   2014-10-09 (Thu, 09 Oct 2014)

  Changed paths:
    M master/buildbot/db/migrate/versions/037_buildrequests_builderid.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/status/builder.py
    M master/buildbot/status/master.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/test/unit/test_schedulers_basic.py
    M master/buildbot/test/unit/test_schedulers_dependent.py
    M master/buildbot/test/unit/test_schedulers_forcesched.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py
    M master/buildbot/test/unit/test_schedulers_timed_NightlyTriggerable.py
    M master/buildbot/test/unit/test_schedulers_trysched.py
    M master/buildbot/test/unit/test_steps_trigger.py
    M master/buildbot/test/util/scheduler.py

  Log Message:
  -----------
  done:
 - SchedulerMixin._addBuildsetReturnValue returns buildernames, but should return builderids
 - BuilderStatus.getPendingBuildRequestStatuses calls db.getBuildRequests (... buildername=...". It's Ok to just assert 0 in this method.
   The whole class will go away soon. Just don't leave it subtly broken
 - update and fix unittests


  Commit: 5b7748ef01e6a2ff2738219b9102b3280aa5c7a4
      https://github.com/buildbot/buildbot/commit/5b7748ef01e6a2ff2738219b9102b3280aa5c7a4
  Author: Xavier Delannoy <xdelannoy at cloudmark.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M master/docs/developer/rtype-buildset.rst

  Log Message:
  -----------
  Fix: master/docs/developer/rtype-buildset.rst about addBuildset returns


  Commit: 2de3ca0b6b3eb923b6f1adf840bcb940f0ee66cd
      https://github.com/buildbot/buildbot/commit/2de3ca0b6b3eb923b6f1adf840bcb940f0ee66cd
  Author: Mikhail Sobolev <sa2ajj at users.noreply.github.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M master/buildbot/data/buildrequests.py
    M master/buildbot/data/buildsets.py
    M master/buildbot/db/buildrequests.py
    M master/buildbot/db/buildsets.py
    A master/buildbot/db/migrate/versions/037_buildrequests_builderid.py
    M master/buildbot/db/model.py
    M master/buildbot/process/botmaster.py
    M master/buildbot/process/builder.py
    M master/buildbot/process/buildrequest.py
    M master/buildbot/process/buildrequestdistributor.py
    M master/buildbot/schedulers/base.py
    M master/buildbot/schedulers/trysched.py
    M master/buildbot/status/builder.py
    M master/buildbot/status/master.py
    M master/buildbot/steps/trigger.py
    M master/buildbot/test/fake/fakedata.py
    M master/buildbot/test/fake/fakedb.py
    M master/buildbot/test/integration/test_custom_buildstep.py
    M master/buildbot/test/unit/test_data_buildrequests.py
    M master/buildbot/test/unit/test_data_buildsets.py
    M master/buildbot/test/unit/test_data_connector.py
    M master/buildbot/test/unit/test_db_buildrequests.py
    M master/buildbot/test/unit/test_db_builds.py
    M master/buildbot/test/unit/test_db_buildsets.py
    M master/buildbot/test/unit/test_db_logs.py
    M master/buildbot/test/unit/test_db_steps.py
    M master/buildbot/test/unit/test_process_builder.py
    M master/buildbot/test/unit/test_process_buildrequest.py
    M master/buildbot/test/unit/test_process_buildrequestdistributor.py
    M master/buildbot/test/unit/test_schedulers_base.py
    M master/buildbot/test/unit/test_schedulers_basic.py
    M master/buildbot/test/unit/test_schedulers_dependent.py
    M master/buildbot/test/unit/test_schedulers_forcesched.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py
    M master/buildbot/test/unit/test_schedulers_timed_NightlyBase.py
    M master/buildbot/test/unit/test_schedulers_timed_NightlyTriggerable.py
    M master/buildbot/test/unit/test_schedulers_timed_Periodic.py
    M master/buildbot/test/unit/test_schedulers_triggerable.py
    M master/buildbot/test/unit/test_schedulers_trysched.py
    M master/buildbot/test/unit/test_status_buildset.py
    M master/buildbot/test/unit/test_status_gerrit.py
    M master/buildbot/test/unit/test_status_mail.py
    M master/buildbot/test/unit/test_steps_trigger.py
    M master/buildbot/test/util/scheduler.py
    M master/docs/developer/database.rst
    M master/docs/developer/rtype-buildrequest.rst
    M master/docs/developer/rtype-buildset.rst

  Log Message:
  -----------
  Merge pull request #1242 from delanne/trac2621_2658

PR for trac #2621 and trac #2658

Fixes ticket:2621
Fixes ticket:2658


Compare: https://github.com/buildbot/buildbot/compare/cf0aec6390d6...2de3ca0b6b3e