[Buildbot-commits] [buildbot/buildbot] ee6605: Don't fake methods that shouldn't be there (#597)

Wed Nov 5 13:42:48 UTC 2014

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: ee66055bf1d41fa9f7912ad5b598cd873e26f1b7
      https://github.com/buildbot/buildbot/commit/ee66055bf1d41fa9f7912ad5b598cd873e26f1b7
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py
    M master/buildbot/test/unit/test_schedulers_timed_Periodic.py

  Log Message:
  -----------
  Don't fake methods that shouldn't be there (#597)

  Commit: 35191c152717d3c3bcdba8b574d549ace60cf154
      https://github.com/buildbot/buildbot/commit/35191c152717d3c3bcdba8b574d549ace60cf154
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py

  Log Message:
  -----------
  Fix some failing tests, convert branch to codebase parameter

  Commit: 8af4cdf665127c439b7b308fd309751840004443
      https://github.com/buildbot/buildbot/commit/8af4cdf665127c439b7b308fd309751840004443
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Use inlineCallbacks in Timed.activate

  Commit: 3a1aa28f4fc713dab6f275b06c3e4243487a2ef1
      https://github.com/buildbot/buildbot/commit/3a1aa28f4fc713dab6f275b06c3e4243487a2ef1
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py

  Log Message:
  -----------
  Add missing codebase properties

Also, sourcestamp['codebase'] is a string, not a dict.

  Commit: 30bc723f4eb103433d36d85164d98d7201caaa19
      https://github.com/buildbot/buildbot/commit/30bc723f4eb103433d36d85164d98d7201caaa19
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py
    M master/buildbot/test/util/scheduler.py

  Log Message:
  -----------
  Call through to fake method, remove unused deferred call

Remove the firstBuildDuration parameter, it's not used anywhere.
Make use of the faked addBuildsetForSourceStampWithDefaults method,
so that the tests may use that instead of the hand-rolled events list.
Also, refactor some tests.

  Commit: 05c0f9f298d61674f5d6b89bff841a8bb99cc256
      https://github.com/buildbot/buildbot/commit/05c0f9f298d61674f5d6b89bff841a8bb99cc256
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  defer.returnValue(None) is the same as "return"

  Commit: 9f70c8563a1263d5096699b18f0f25190c17fd0a
      https://github.com/buildbot/buildbot/commit/9f70c8563a1263d5096699b18f0f25190c17fd0a
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py

  Log Message:
  -----------
  Prefer 'codebases' over 'branch' parameter

  Commit: 2bd71a3cd60a83520dafd073c4e8b7251b903852
      https://github.com/buildbot/buildbot/commit/2bd71a3cd60a83520dafd073c4e8b7251b903852
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py

  Log Message:
  -----------
  Don't import config

  Commit: 549dfd976e0b9b0875e6b821417d216c56f94ed8
      https://github.com/buildbot/buildbot/commit/549dfd976e0b9b0875e6b821417d216c56f94ed8
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Use kwargs.pop instead of .get+del

  Commit: 57f64bb309225a8a47d6221f5ed094fbeb13bac6
      https://github.com/buildbot/buildbot/commit/57f64bb309225a8a47d6221f5ed094fbeb13bac6
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/basic.py

  Log Message:
  -----------
  defer.inlineCallbacks ftw

  Commit: e0714d2847e29f6d4dbbaf0033c812a468f6ed47
      https://github.com/buildbot/buildbot/commit/e0714d2847e29f6d4dbbaf0033c812a468f6ed47
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/base.py
    M master/buildbot/test/unit/test_schedulers_base.py
    M master/buildbot/test/unit/test_schedulers_basic.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py

  Log Message:
  -----------
  Allow getCodebaseDict to return a deferred.

Also sched.activate() might become async. Adjust tests accordingly.

  Commit: f4a461808d5d9ab78ac9b49e5ee032406d344fdc
      https://github.com/buildbot/buildbot/commit/f4a461808d5d9ab78ac9b49e5ee032406d344fdc
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_basic.py
    A master/buildbot/util/codebase.py

  Log Message:
  -----------
  Move createAbsoluteSourceStamps logic to mixin

  Commit: 290c92e9cddbd65e4bee7a7d863c166a02588748
      https://github.com/buildbot/buildbot/commit/290c92e9cddbd65e4bee7a7d863c166a02588748
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Refactor some mildly confusing ifs

  Commit: 38c8912e019c7164477274d1549721f49caf7c0c
      https://github.com/buildbot/buildbot/commit/38c8912e019c7164477274d1549721f49caf7c0c
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/test/unit/test_schedulers_basic.py
    A master/buildbot/test/unit/test_util_codebase.py

  Log Message:
  -----------
  Add tests for AbsoluteSourceStampsMixin

Also, remove 3 tests from test_schedulers_basic. The desired
functionality is implemented and tested in the mixin.

  Commit: 074fac568e566ada7a9e72b86cc6cb7df1dc8293
      https://github.com/buildbot/buildbot/commit/074fac568e566ada7a9e72b86cc6cb7df1dc8293
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Move AbsoluteSourceStampMixin up the inheritance chain

  Commit: ae0cff23b34d9b78952bd36694a7c0bcf450388a
      https://github.com/buildbot/buildbot/commit/ae0cff23b34d9b78952bd36694a7c0bcf450388a
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Add a method to start a build with collected changes

This can be used by the startBuild implementations. If the scheduler
has collected and classified any changes, it will use
`addBuildsetForChanges` and flush the change classifications. If there
are no changes it will use `addBuildsetForSourceStampsWithDefaults`.
If `onlyIfChanged` was given and there are no important changes, the
method will return without triggering any builds. Collected changes
won't be flushed from the database.

  Commit: afbabd0ad43ac476062b77daf9fa947e374ef236
      https://github.com/buildbot/buildbot/commit/afbabd0ad43ac476062b77daf9fa947e374ef236
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Fix onlyIfChanged, adjust Periodic

  Commit: 040ae54fe7c8c7610b6ad044bc820b55a4cb20d3
      https://github.com/buildbot/buildbot/commit/040ae54fe7c8c7610b6ad044bc820b55a4cb20d3
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_timed_NightlyTriggerable.py

  Log Message:
  -----------
  Fix NightlyTriggerable

  Commit: e631214efe18b73e97789720208245e035c926a1
      https://github.com/buildbot/buildbot/commit/e631214efe18b73e97789720208245e035c926a1
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Move onlyIfChanged to Timed scheduler base class.

  Commit: 15b399c2bd71767547f7745cb0852f5dc995e6a3
      https://github.com/buildbot/buildbot/commit/15b399c2bd71767547f7745cb0852f5dc995e6a3
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Wrap some overly long lines

  Commit: 641520a68bb926594b7870e9310731907c087432
      https://github.com/buildbot/buildbot/commit/641520a68bb926594b7870e9310731907c087432
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Allow createAbsoluteSourceStamps without onlyIfChanged

  Commit: 4a1d706ab38a4d34f4ef2f8d6c5dec5fc823da05
      https://github.com/buildbot/buildbot/commit/4a1d706ab38a4d34f4ef2f8d6c5dec5fc823da05
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Let's not redefine the builtin filter(), mkay?

  Commit: 8ec6c328456c13f393dd10f5cffd51b4d97e275f
      https://github.com/buildbot/buildbot/commit/8ec6c328456c13f393dd10f5cffd51b4d97e275f
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Start consuming changes in Timed (instead of Nightly)

  Commit: 32d19d6b31f95e72fb74742ad171d2f462babbbf
      https://github.com/buildbot/buildbot/commit/32d19d6b31f95e72fb74742ad171d2f462babbbf
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/docs/manual/cfg-schedulers.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Update manual and relnotes for timed scheduler changes.

  Commit: 11b9d6a42615f877e6850cbe4e963b0837d0db51
      https://github.com/buildbot/buildbot/commit/11b9d6a42615f877e6850cbe4e963b0837d0db51
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/test/unit/test_schedulers_dependent.py
    M master/buildbot/test/unit/test_schedulers_trysched.py
    M master/buildbot/test/util/scheduler.py

  Log Message:
  -----------
  Fix typo(?) in scheduler helper

The method is called addBuildsetForSourceStamps (plural) not
addBuildsetForSourceStamp.

  Commit: 1f73d3655059216861eb24e73f17bfe25c679859
      https://github.com/buildbot/buildbot/commit/1f73d3655059216861eb24e73f17bfe25c679859
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/timed.py

  Log Message:
  -----------
  Fixed some minor screwups

  Commit: aa7a549ea65cbd7fc7c6ecf516ae9111e8cebe48
      https://github.com/buildbot/buildbot/commit/aa7a549ea65cbd7fc7c6ecf516ae9111e8cebe48
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_basic.py
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Remove preStartConsumingChanges, startTimedSchedulerService

  Commit: 211797d9ab88d46116b93ab64f26537fc2707f28
      https://github.com/buildbot/buildbot/commit/211797d9ab88d46116b93ab64f26537fc2707f28
  Author: Jonas Pommerening <jonas.pommerening at gmail.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/util/codebase.py

  Log Message:
  -----------
  Remove superfluous assert

  Commit: ea2ec0785b845ad53a535ed48d325babceae2341
      https://github.com/buildbot/buildbot/commit/ea2ec0785b845ad53a535ed48d325babceae2341
  Author: Xavier Delannoy <xdelannoy at cloudmark.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py

  Log Message:
  -----------
  autopep8

  Commit: ccb7cfd52dd1835634234991868236667f418244
      https://github.com/buildbot/buildbot/commit/ccb7cfd52dd1835634234991868236667f418244
  Author: Xavier Delannoy <xdelannoy at cloudmark.com>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py

  Log Message:
  -----------
   - add code to filter on self.branch if it's set
 - don't filter on codebase as dustin suggested
 - add a parameter change_filter

  Commit: ccc1eb5100da25ad9177b32c401751d5136a462e
      https://github.com/buildbot/buildbot/commit/ccc1eb5100da25ad9177b32c401751d5136a462e
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-11-05 (Wed, 05 Nov 2014)

  Changed paths:
    M master/buildbot/schedulers/base.py
    M master/buildbot/schedulers/basic.py
    M master/buildbot/schedulers/timed.py
    M master/buildbot/test/unit/test_schedulers_base.py
    M master/buildbot/test/unit/test_schedulers_basic.py
    M master/buildbot/test/unit/test_schedulers_dependent.py
    M master/buildbot/test/unit/test_schedulers_timed_Nightly.py
    M master/buildbot/test/unit/test_schedulers_timed_NightlyTriggerable.py
    M master/buildbot/test/unit/test_schedulers_timed_Periodic.py
    M master/buildbot/test/unit/test_schedulers_trysched.py
    A master/buildbot/test/unit/test_util_codebase.py
    M master/buildbot/test/util/scheduler.py
    A master/buildbot/util/codebase.py
    M master/docs/manual/cfg-schedulers.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge delanne/buildbot:fix-timed-schedulers (PR #1325)

Compare: https://github.com/buildbot/buildbot/compare/8716bd075767...ccc1eb5100da