[Buildbot-commits] [buildbot/buildbot] d6eb7b: status_json: Allow double escaping for resources i...

GitHub noreply at github.com
Mon Mar 31 14:04:23 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: d6eb7bf6b650de4ca394dcdba6c2ab3e6dc86caf
      https://github.com/buildbot/buildbot/commit/d6eb7bf6b650de4ca394dcdba6c2ab3e6dc86caf
  Author: Anton Lofgren <alofgren at op5.com>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M master/buildbot/status/web/status_json.py

  Log Message:
  -----------
  status_json: Allow double escaping for resources in select

This patch provides a workaround for an issue that would cause queries
of the form

"select=builders/my%20slashed%2Fbuilder"

to be interpreted as a hierarchy of separate resources:

builders
 - my slashed
   - builder

Instead of the intended:

builders
 - my slashed/builder

This way, we can double escape resources with specially treated
characters in them (such as slashes), and still retrieve them properly.

For instance, the query above becomes:

"select=builders/my%2520slashed%252Fbuilder"

instead, and renders the desired result.

Signed-off-by: Anton Lofgren <alofgren at op5.com>


  Commit: 910e14ba8cac51c65ffaf2e31e54212cd8b2994e
      https://github.com/buildbot/buildbot/commit/910e14ba8cac51c65ffaf2e31e54212cd8b2994e
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M master/buildbot/status/web/status_json.py

  Log Message:
  -----------
  Merge catharsis/buildbot:status-json-double-escape-resources (PR #1115)


Compare: https://github.com/buildbot/buildbot/compare/17b8f9459e7a...910e14ba8cac


More information about the Commits mailing list