[Buildbot-commits] [Buildbot] #371: ShellCommand argument "logfiles" does not properly work for HTML log files

Buildbot trac trac at buildbot.net
Wed Mar 19 01:52:02 UTC 2014


#371: ShellCommand argument "logfiles" does not properly work for HTML log files
------------------------+--------------------
Reporter:  cli          |       Owner:
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.9.0
 Version:               |  Resolution:
Keywords:  web          |
------------------------+--------------------

Comment (by dustin):

 The code you snipped is in `LoggingBuildStep`, which is always old-style,
 so it doesn't need to handle a Deferred.  And while `useLog` will accept
 whatever you give it, the command will unwrap any !SyncLogFileWrapper
 instances that it receives before actually using them.  So I think that
 this is quite possible, even for old-style steps, although I'd have no
 problem seeing it only implemented for new-style steps.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/371#comment:12>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list