[Buildbot-commits] [Buildbot] #2601: Properties sent by sendchange command are not used during build

[Buildbot trac]

#2601: Properties sent by sendchange command are not used during build
-----------------------+--------------------
Reporter:  jollyroger  |       Owner:
    Type:  defect      |      Status:  new
Priority:  critical    |   Milestone:  0.9.0
 Version:              |  Resolution:
Keywords:              |
-----------------------+--------------------

Comment (by tardyp):

 Looking at the code, I dont see why this would not work.

 a possible change could be:
         if kwargs.get('properties'):
             kwargs['properties'] = dict((ascii2unicode(k), v)
                                         for k, v in
 kwargs['properties'].iteritems())

 which converts the key to unicode, so maybe this is an encoding issues
 in process/build.py,
 change properties are indeed mixed in:

         # from the SourceStamps, which have properties via Change
         for change in self.allChanges():
             props.updateFromProperties(change.properties)

 jollyroger: could you add some prints after those lines, trying to debug
 this problem?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2601#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation