[Buildbot-commits] [buildbot/buildbot] 156102: add a poll.method decorator

[GitHub]

  Branch: refs/heads/nine
  Home:   https://github.com/buildbot/buildbot
  Commit: 15610215f50d2649514d9019909ce16ca67f21c8
      https://github.com/buildbot/buildbot/commit/15610215f50d2649514d9019909ce16ca67f21c8
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    A master/buildbot/test/unit/test_util_poll.py
    A master/buildbot/util/poll.py
    M master/docs/developer/utils.rst

  Log Message:
  -----------
  add a poll.method decorator


  Commit: 257a1adb9126a8a4821698f4ebe25757ab73aa47
      https://github.com/buildbot/buildbot/commit/257a1adb9126a8a4821698f4ebe25757ab73aa47
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M master/buildbot/changes/base.py
    M master/buildbot/test/unit/test_util_misc.py
    M master/buildbot/util/__init__.py
    M master/buildbot/util/misc.py
    M master/docs/developer/style.rst
    M master/docs/developer/utils.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  remove unnecessary SerializedInvocation


  Commit: f54d7531fcc17cd02707f6ed620aad0fab750cdd
      https://github.com/buildbot/buildbot/commit/f54d7531fcc17cd02707f6ed620aad0fab750cdd
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M master/buildbot/changes/base.py
    M master/docs/developer/classes.rst
    A master/docs/developer/cls-changesources.rst
    M master/docs/manual/customization.rst

  Log Message:
  -----------
  remove PollingChangeSource docstrings


  Commit: c0b040750bf2abd9f102910c13131762915f1fc0
      https://github.com/buildbot/buildbot/commit/c0b040750bf2abd9f102910c13131762915f1fc0
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-05-25 (Sun, 25 May 2014)

  Changed paths:
    M master/buildbot/changes/base.py
    M master/buildbot/status/web/hooks/poller.py
    M master/buildbot/test/unit/test_status_web_hooks_poller.py

  Log Message:
  -----------
  Fix poller hook

This is still not appropriate for nine.  Rather than forcing local
change sources, it should be sending a message to force remote change
sources.  But, good enough for the moment.


  Commit: c67feedd2ba0aa6169100340e7fb281a56bfa86e
      https://github.com/buildbot/buildbot/commit/c67feedd2ba0aa6169100340e7fb281a56bfa86e
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-06-11 (Wed, 11 Jun 2014)

  Changed paths:
    M master/buildbot/changes/base.py
    M master/buildbot/status/web/hooks/poller.py
    M master/buildbot/test/unit/test_status_web_hooks_poller.py
    M master/buildbot/test/unit/test_util_misc.py
    A master/buildbot/test/unit/test_util_poll.py
    M master/buildbot/util/__init__.py
    M master/buildbot/util/misc.py
    A master/buildbot/util/poll.py
    M master/docs/developer/classes.rst
    A master/docs/developer/cls-changesources.rst
    M master/docs/developer/style.rst
    M master/docs/developer/utils.rst
    M master/docs/manual/customization.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge djmitche/buildbot:bug2442 (PR #1149)

Conflicts:
	master/buildbot/util/__init__.py

+ pyflakes
+ fix docs


  Commit: 26022060f7ac5702f92f239feb1d6c757c51a3e2
      https://github.com/buildbot/buildbot/commit/26022060f7ac5702f92f239feb1d6c757c51a3e2
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-06-11 (Wed, 11 Jun 2014)

  Changed paths:
    M master/buildbot/changes/base.py
    M master/buildbot/test/unit/test_util_poll.py

  Log Message:
  -----------
  change imports to avoid shadowing

in
```
from buildbot.util import poll

class Foo:
    @poll.method
    def someMethod(self):
  pass
    def poll(self):
  pass
```

The `poll` in `@poll.method` correctly refers to the module.  However,
if the order of the methods is reversed, it refers instead to the `poll`
method in the class scope.

Pyflakes only detects this in the problematic ordering, while pylint
detects it even in the working order.  Pylint is probably right -
re-ordering methods shouldn't change behavior!


Compare: https://github.com/buildbot/buildbot/compare/39df5f72935f...26022060f7ac