[Buildbot-commits] [buildbot/buildbot] cd309d: buildstep.py: remove "ShellCommand" in LoggingBuil...

Tue Jan 21 23:22:54 UTC 2014

  Branch: refs/heads/nine
  Home:   https://github.com/buildbot/buildbot
  Commit: cd309d44195f282a33677833bcef1e16c061af24
      https://github.com/buildbot/buildbot/commit/cd309d44195f282a33677833bcef1e16c061af24
  Author: Ion Alberdi <ion.alberdi at intel.com>
  Date:   2014-01-13 (Mon, 13 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py

  Log Message:
  -----------
  buildstep.py: remove "ShellCommand" in LoggingBuildStep

some logging messages had "ShellCommand" hardcoded.

this commit writes the name of the class instead.

Signed-off-by: Ion Alberdi <ion.alberdi at intel.com>

  Commit: 922108ed101d36480993f3e611e15e7b42e0c8d7
      https://github.com/buildbot/buildbot/commit/922108ed101d36480993f3e611e15e7b42e0c8d7
  Author: Ion Alberdi <ion.alberdi at intel.com>
  Date:   2014-01-14 (Tue, 14 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/shell.py
    M master/buildbot/test/unit/test_steps_shell.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/developer/style.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  buildstep: create ShellBaseStep

refactor what is necesary to execute a shell command
in a slave, in a mother class.

existing unit test from shellstep cover that refactoring.

Signed-off-by: Ion Alberdi <ion.alberdi at intel.com>

  Commit: 7c3ff5c6707daa4a10c6f45ba6211629086e1b5f
      https://github.com/buildbot/buildbot/commit/7c3ff5c6707daa4a10c6f45ba6211629086e1b5f
  Author: Ion Alberdi <ion.alberdi at intel.com>
  Date:   2014-01-17 (Fri, 17 Jan 2014)

  Changed paths:
    M master/buildbot/interfaces.py
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/status/results.py
    M master/buildbot/steps/shell.py
    A master/buildbot/steps/shellsequence.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/unit/test_process_buildstep.py
    A master/buildbot/test/unit/test_steps_shellsequence.py
    M master/buildbot/test/unit/test_steps_slave.py
    M master/buildbot/test/util/config.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  shellsequence: implement step

this steps permits one to launch multiple shell
commands in a single step. Each shell command
has its own optional stdio log, and haltOnFailure, etc parameter.
They however, all share the same workdir, use-pty, env parameters.

the skipping of commands can be driven by overriding
one method of that class (see doc).

Signed-off-by: Ion Alberdi <ion.alberdi at intel.com>

  Commit: 9b15a8cd18d166bed81f7eb752a85ad1d9bdf06b
      https://github.com/buildbot/buildbot/commit/9b15a8cd18d166bed81f7eb752a85ad1d9bdf06b
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/interfaces.py
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/status/results.py
    M master/buildbot/steps/shell.py
    A master/buildbot/steps/shellsequence.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/buildbot/test/unit/test_steps_shell.py
    A master/buildbot/test/unit/test_steps_shellsequence.py
    M master/buildbot/test/unit/test_steps_slave.py
    M master/buildbot/test/util/config.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/developer/style.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge yetanotherion/buildbot:listofshellcommands (PR #1045)

  Commit: b47d52097b2d97acaae2579c7cb8f6dc89dcef08
      https://github.com/buildbot/buildbot/commit/b47d52097b2d97acaae2579c7cb8f6dc89dcef08
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/test/unit/test_steps_shellsequence.py
    M master/docs/developer/cls-buildsteps.rst

  Log Message:
  -----------
  pep8, whitespace, etc.

  Commit: b7f603239dfbcc73f0aa1d365a2bd4aef531ae21
      https://github.com/buildbot/buildbot/commit/b7f603239dfbcc73f0aa1d365a2bd4aef531ae21
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/steps/shellsequence.py
    M master/buildbot/test/unit/test_steps_shellsequence.py

  Log Message:
  -----------
  rename 'cmd' to 'command' for consistency with ShellCommand

  Commit: 34a9530c994fc99e66a0acbf1ab21930fb51ded5
      https://github.com/buildbot/buildbot/commit/34a9530c994fc99e66a0acbf1ab21930fb51ded5
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/unit/test_process_buildstep.py

  Log Message:
  -----------
  clarify log messages

  Commit: e8de2894e11027e5de57432ec4b324a6d205724a
      https://github.com/buildbot/buildbot/commit/e8de2894e11027e5de57432ec4b324a6d205724a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py

  Log Message:
  -----------
  revert to using _describe, but remove its docstring; see #2670

  Commit: de05e332a24fccd9f8b494f2ad505489627d26bc
      https://github.com/buildbot/buildbot/commit/de05e332a24fccd9f8b494f2ad505489627d26bc
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/shell.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/oldsource.py
    M master/buildbot/steps/vstudio.py
    M master/buildbot/test/unit/test_process_buildstep.py

  Log Message:
  -----------
  revert LoggingBuildStep and everything that depends on it, and merge the modifications to it into ShellBaseStep

  Commit: f95c7d0b4dae4e09e74ba93eefe66d8b29baed73
      https://github.com/buildbot/buildbot/commit/f95c7d0b4dae4e09e74ba93eefe66d8b29baed73
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/docs/developer/style.rst

  Log Message:
  -----------
  edit the style section a bit

  Commit: 27d28c8132ccd845e924843567c6acf81b53caea
      https://github.com/buildbot/buildbot/commit/27d28c8132ccd845e924843567c6acf81b53caea
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  edit ShellSequence docs

  Commit: fbec3eb7db1adaaf6714d4dd6f2f33116696123f
      https://github.com/buildbot/buildbot/commit/fbec3eb7db1adaaf6714d4dd6f2f33116696123f
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/process/remotecommand.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/repo.py
    M master/buildbot/test/fake/fakebuild.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/unit/test_process_buildstep.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/manual/cfg-builders.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Revert LoggingBuildStep, add CommandMixin and ShellMixin

These two mixin classes will be the new style for shell commands.
They're organized to be called from a `run` method, rather than
overriding lots of confusing hook methods like `createSummary` and
`evaluateCommand`.

  Commit: d52ac5cb4102828c9e26d4efb50ff5880450c2d0
      https://github.com/buildbot/buildbot/commit/d52ac5cb4102828c9e26d4efb50ff5880450c2d0
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/steps/shellsequence.py
    M master/buildbot/test/unit/test_steps_shellsequence.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  refactor ShellSequence to use ShellMixin

  Commit: 55d8f0373403f19a0080e2f869565f80010a9696
      https://github.com/buildbot/buildbot/commit/55d8f0373403f19a0080e2f869565f80010a9696
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/buildbot/interfaces.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/status/results.py
    M master/buildbot/steps/shellsequence.py
    A master/buildbot/test/unit/test_status_results.py
    M master/docs/developer/results.rst

  Log Message:
  -----------
  refactor result calculations into results.py

  Commit: 9d96a068e142dccb9633db18f52eddf700bad04b
      https://github.com/buildbot/buildbot/commit/9d96a068e142dccb9633db18f52eddf700bad04b
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-20 (Mon, 20 Jan 2014)

  Changed paths:
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/manual/customization.rst

  Log Message:
  -----------
  update the customization docs to point to CommandMixin/ShellMixin

  Commit: d331b90194c3992445bf84f71a056f967a17ee51
      https://github.com/buildbot/buildbot/commit/d331b90194c3992445bf84f71a056f967a17ee51
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-21 (Tue, 21 Jan 2014)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/status/results.py
    M master/buildbot/steps/shellsequence.py
    M master/buildbot/test/unit/test_status_results.py
    M master/docs/developer/results.rst

  Log Message:
  -----------
  rename computeResultAndContinuation to computeResultAndTermination

  Commit: 6e62c9091eb15f37c64f7ed017aa8b72156a8f30
      https://github.com/buildbot/buildbot/commit/6e62c9091eb15f37c64f7ed017aa8b72156a8f30
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-21 (Tue, 21 Jan 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/docs/manual/cfg-buildsteps.rst

  Log Message:
  -----------
  docs tweaks suggested by @yetanotherion

  Commit: 44ffcfc664cb450c8cf492ea5cb17bb893a7bf4f
      https://github.com/buildbot/buildbot/commit/44ffcfc664cb450c8cf492ea5cb17bb893a7bf4f
  Author: Dustin J. Mitchell <dustin at v.igoro.us>
  Date:   2014-01-21 (Tue, 21 Jan 2014)

  Changed paths:
    M master/buildbot/process/build.py

  Log Message:
  -----------
  Update comment

Let's be honest, I'm just testing GitHub's ability to edit PR's from the web..

  Commit: edcdff3cb009341ceed43ffeda1ca5dba76267b7
      https://github.com/buildbot/buildbot/commit/edcdff3cb009341ceed43ffeda1ca5dba76267b7
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2014-01-21 (Tue, 21 Jan 2014)

  Changed paths:
    M master/buildbot/process/build.py
    M master/buildbot/process/buildstep.py
    M master/buildbot/status/results.py
    A master/buildbot/steps/shellsequence.py
    M master/buildbot/steps/slave.py
    M master/buildbot/steps/source/repo.py
    M master/buildbot/test/fake/fakebuild.py
    M master/buildbot/test/fake/remotecommand.py
    M master/buildbot/test/unit/test_process_buildstep.py
    A master/buildbot/test/unit/test_status_results.py
    M master/buildbot/test/unit/test_steps_shell.py
    A master/buildbot/test/unit/test_steps_shellsequence.py
    M master/buildbot/test/unit/test_steps_slave.py
    M master/buildbot/test/util/config.py
    M master/docs/developer/cls-buildsteps.rst
    M master/docs/developer/results.rst
    M master/docs/developer/style.rst
    M master/docs/manual/cfg-builders.rst
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/manual/customization.rst

  Log Message:
  -----------
  Merge branch '9/shell-refactoring' of git://github.com/djmitche/buildbot into nine

Compare: https://github.com/buildbot/buildbot/compare/11eb83f93059...edcdff3cb009