[Buildbot-commits] [Buildbot] #2671: Master-side Git step: 'git clone' fails, but Git step is still continued

[Buildbot trac]

#2671: Master-side Git step: 'git clone' fails, but Git step is still continued
-------------------+-----------------------
Reporter:  krf     |      Owner:
    Type:  defect  |     Status:  new
Priority:  major   |  Milestone:  undecided
 Version:  0.8.8   |   Keywords:
-------------------+-----------------------
 Excerpt from the Git step log output:

 {{{
 'git' 'clone' '--branch' 'master' 'gitolite at somehost:someproject.git' '.'
 '--progress'
  in dir C:\Buildbot\someproject-windows\source (timeout 1200 secs)
  watching logfiles {}
  argv: ['git', 'clone', '--branch', 'master',
 'gitolite at somehost:someproject.git', '.', '--progress']
  environment:
   (...)
 Cloning into '.'...
 fatal: 'someproject.git' does not appear to be a git repository
 fatal: Could not read from remote repository.

 Please make sure you have the correct access rights
 and the repository exists.
 program finished with exit code 128
 elapsedTime=2.199000
 'git' 'submodule' 'update' '--init' '--recursive'
  in dir C:\Buildbot\someproject-windows\source (timeout 1200 secs)
  watching logfiles {}
  argv: ['git', 'submodule', 'update', '--init', '--recursive']
  environment:
   (...)
 program finished with exit code 0
 }}}

 Problem: 'git clone' clearly failed (exit code 128), but the Git step
 isn't aborted.

 Buildbot still runs Git commands that may even modify the parent Git root.
 (We have buildslave.tac, etc. under version control).

 Proposed solution: The Git step should fail in case 'git clone' fails

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2671>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation