[Buildbot-commits] [Buildbot] #2670: describe/_describe are backward

[Buildbot trac]

#2670: describe/_describe are backward
----------------------+--------------------
Reporter:  dustin     |      Owner:  dustin
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  0.8.9
 Version:  0.8.8      |   Keywords:
----------------------+--------------------
 The !BuildStep method {{{describe}}} calls {{{_describe}}}, then adds a
 suffix.  Yet, {{{_describe}}} is the one that subclasses might want to
 override.

 I think that the fix here is to add a {{{getDescription}}} method that
 will call {{{describe}}} and add the suffix, then call
 {{{getDescription}}} instead of {{{describe}}} everywhere it matters in
 the process code.

 There's a more subtle confusion here, though, between
 {{{step_status.setText}}}, which pushes a status string, and
 {{{step.describe}}}, which pulls one.  As a result, code all over the
 place is calling these two methods.  It might be nice to de-confuse this,
 at least in new-style steps in nine.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2670>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation